Skip to content

runtime: add an example for AddCleanup [1.24 backport] #72796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Mar 11, 2025 · 2 comments
Closed

runtime: add an example for AddCleanup [1.24 backport] #72796

gopherbot opened this issue Mar 11, 2025 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. Documentation Issues describing a change to documentation.
Milestone
Go1.24.2

Comments

@gopherbot
Copy link
Contributor

@cagedmantis requested issue #72795 to be considered for backport to the next 1.24 minor release.

@gopherbot please backport to Go 1.24.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 11, 2025
@gopherbot gopherbot mentioned this issue Mar 11, 2025
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Mar 11, 2025
@gopherbot gopherbot added this to the Go1.24.2 milestone Mar 11, 2025
@cagedmantis cagedmantis added the Documentation Issues describing a change to documentation. label Mar 11, 2025
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/656815 mentions this issue: [release-branch.go1.24] runtime: Added usage example for the runtime.AddCleanup() function.

@dr2chase dr2chase added the CherryPickApproved Used during the release process for point releases label Mar 12, 2025
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Mar 12, 2025
gopherbot pushed a commit that referenced this issue Mar 17, 2025
@streamdp @cherrymui
[release-branch.go1.24] runtime: Added usage example for the runtime.…
4524009 
…AddCleanup() function.

The existing description of the function lacks usage examples, which makes it difficult to understand, so I added one.

There is no open issue about this, since the implementation seems trivial.

For #72795
Fixes #72796

Change-Id: I96b29f0b21d1c7fda04128239633c8a2fc36fef2
Reviewed-on: https://go-review.googlesource.com/c/go/+/649995
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
(cherry picked from commit 4c75671)
Reviewed-on: https://go-review.googlesource.com/c/go/+/656815
Reviewed-by: Cherry Mui <cherryyz@google.com>
@gopherbot
Copy link
Contributor Author

Closed by merging CL 656815 (commit 4524009) to release-branch.go1.24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. Documentation Issues describing a change to documentation.
Projects
None yet
Milestone
Go1.24.2
Development

No branches or pull requests
3 participants
@cagedmantis @dr2chase @gopherbot