Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: completion has wrong textedit in some cases #72753

Open
xzbdmw opened this issue Mar 9, 2025 · 2 comments
Open

x/tools/gopls: completion has wrong textedit in some cases #72753

xzbdmw opened this issue Mar 9, 2025 · 2 comments
Assignees
@adonovan
Labels
BugReport Issues describing a possible bug in the Go implementation. gopls/completion Issues related to auto-completion in gopls. gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Backlog

Comments

@xzbdmw
Copy link

xzbdmw commented Mar 9, 2025 •
edited
Loading

gopls version

tested on latest master branch

go env

.

What did you do?

func f(left,right string){
	left,ri
}

cursor on ri, press enter to confirm right candidate. I also tested in vscode, problem is the same.

iShot_2025-03-09_22.45.05.mp4

textDocument/completion response:

{
      detail = "string",
      documentation = {
        kind = "markdown",
        value = ""
      },
      filterText = "right",
      insertTextFormat = 2,
      kind = 6,
      label = "right",
      sortText = "00001",
      textEdit = {
        insert = {
          ["end"] = {
            character = 7,
            line = 46
          },
          start = {
            character = 7, ------This is wrong
            line = 46
          }
        },
        newText = "right",
        replace = {
          ["end"] = {
            character = 7,
            line = 46
          },
          start = {
            character = 7,
            line = 46
          }
        }
      }
    }

What did you see happen?

func f(left,right string){
	left,riright
}

What did you expect to see?

func f(left,right string){
	left,right
}

Editor and settings

neovim, vscode

Logs

No response
@xzbdmw xzbdmw added gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. labels Mar 9, 2025
@gopherbot gopherbot added this to the Unreleased milestone Mar 9, 2025
@xzbdmw xzbdmw changed the title x/tools/gopls: wrong textedit in some cases x/tools/gopls: completion has wrong textedit in some cases Mar 9, 2025
@gabyhelp
Copy link

gabyhelp commented Mar 9, 2025

Related Issues

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@gabyhelp gabyhelp added the BugReport Issues describing a possible bug in the Go implementation. label Mar 9, 2025
@h9jiang
Copy link
Member

h9jiang commented Mar 10, 2025

This behavior seems to be there since v0.16, I tried with v0.16 17 and 18 they all end up in this state. I'm not very familiar with auto-completion so I will leave it to @adonovan to determine if this is a bug we can fix,

@h9jiang h9jiang modified the milestones: Unreleased, Backlog Mar 13, 2025
@adonovan adonovan added the gopls/completion Issues related to auto-completion in gopls. label Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adonovan adonovan

Labels
BugReport Issues describing a possible bug in the Go implementation. gopls/completion Issues related to auto-completion in gopls. gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@adonovan @gopherbot @h9jiang @xzbdmw @gabyhelp