Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http/httputil: DumpRequest doesn't dump Content-Length field in the header #7215

Closed
ghost opened this issue Jan 27, 2014 · 5 comments
Closed

Comments

@ghost
Copy link

ghost commented Jan 27, 2014

see http://play.golang.org/p/8UNjmEa6AP
@minux
Copy link
Member

minux commented Jan 27, 2014

Comment 1:

Labels changed: added release-none, repo-main.

@gopherbot
Copy link

Comment 2 by lihaohua90:

Have another try using httputil.DumpRequestOut.

@gopherbot
Copy link

Comment 3 by steven.hartland@multiplay.co.uk:

DumpRequestOut is the correct method but you'll also need the following after the reader:
    req.URL.Scheme = "http"
    req.URL.Host = req.Host

@ghost ghost added new labels May 24, 2014
@bradfitz bradfitz removed the new label Dec 18, 2014
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@odeke-em
Copy link
Member

odeke-em commented Apr 9, 2016

What is the status on this issue? Has it been accepted that we should improve DumpRequestOut or should DumpRequest be fixed?
I ask because I've worked offline on a CL https://go-review.googlesource.com/21790 to get this behavior in for DumpRequest it but I have no trouble scrapping or updating it (it was just a warm up CL).

@gopherbot
Copy link

CL https://golang.org/cl/21790 mentions this issue.

@golang golang locked and limited conversation to collaborators Apr 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants