Skip to content

cmd/compile: out of memory [1.24 backport] #72067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Mar 2, 2025 · 2 comments
Closed

cmd/compile: out of memory [1.24 backport] #72067

gopherbot opened this issue Mar 2, 2025 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.24.2

Comments

@gopherbot
Copy link
Contributor

@Jorropo requested issue #72063 to be considered for backport to the next 1.24 minor release.

@gopherbot please backport to the next go1.24 release.

Valid code that used to compile with 1.23.6 now fails to do so while using all the memory on the system.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 2, 2025
@gopherbot gopherbot mentioned this issue Mar 2, 2025
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Mar 2, 2025
@gopherbot gopherbot added this to the Go1.24.1 milestone Mar 2, 2025
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/654517 mentions this issue: [release-branch.go1.24] cmd/compile: fix out of memory when inlining closure

@gopherbot gopherbot modified the milestones: Go1.24.1, Go1.24.2 Mar 4, 2025
@JunyangShao JunyangShao added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Mar 5, 2025
gopherbot pushed a commit that referenced this issue Mar 5, 2025
@cuonglm @gopherbot
[release-branch.go1.24] cmd/compile: fix out of memory when inlining …
0ace2d8 
…closure

CL 629195 strongly favor closure inlining, allowing closures to be
inlined more aggressively.

However, if the closure body contains a call to a function, which itself
is one of the call arguments, it causes the infinite inlining.

Fixing this by prevent this kind of functions from being inlinable.

Fixes #72067

Change-Id: I5fb5723a819b1e2c5aadb57c1023ec84ca9fa53c
Reviewed-on: https://go-review.googlesource.com/c/go/+/654195
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/654517
Commit-Queue: Junyang Shao <shaojunyang@google.com>
Auto-Submit: Junyang Shao <shaojunyang@google.com>
Reviewed-by: Junyang Shao <shaojunyang@google.com>
Reviewed-by: Jorropo <jorropo.pgm@gmail.com>
@gopherbot
Copy link
Contributor Author

Closed by merging CL 654517 (commit 0ace2d8) to release-branch.go1.24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.24.2
Development

No branches or pull requests
2 participants
@gopherbot @JunyangShao