Skip to content

x/benchmarks/sweet: re-enable gVisor benchmarks #72042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
prattmic opened this issue Feb 28, 2025 · 2 comments
Open

x/benchmarks/sweet: re-enable gVisor benchmarks #72042

prattmic opened this issue Feb 28, 2025 · 2 comments
Assignees
@prattmic
Labels
NeedsFix The path to resolution is known, but the work has not been done. Other None of the above. Performance
Milestone
Backlog

Comments

@prattmic
Copy link
Member

The gVisor benchmarks were disabled in https://go.dev/cl/653755 due to breakage from https://go.dev/cl/652276. See #68437 (comment).

We should re-enable once it is fixed upstream.
@prattmic prattmic self-assigned this Feb 28, 2025
@prattmic prattmic added this to the Backlog milestone Feb 28, 2025
@prattmic prattmic added Performance NeedsFix The path to resolution is known, but the work has not been done. labels Feb 28, 2025
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/653755 mentions this issue: sweet: disable gVisor by default

@gabyhelp gabyhelp added the Other None of the above. label Feb 28, 2025
gopherbot pushed a commit to golang/benchmarks that referenced this issue Feb 28, 2025
@prattmic @gopherbot
sweet: disable gVisor by default
Loading
Loading status checks…
85abf5a 
gVisor is broken as of https://go.dev/cl/652276.

For golang/go#72042.
Fixes golang/go#68437.

Change-Id: I6a6a636caa3a65c3c58d30ed26d877dba9378afe
Reviewed-on: https://go-review.googlesource.com/c/benchmarks/+/653755
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
@gabyhelp
Copy link

Related Issues

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prattmic prattmic

Labels
NeedsFix The path to resolution is known, but the work has not been done. Other None of the above. Performance
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@prattmic @gopherbot @gabyhelp