Skip to content

x/build/env/freebsd-amd64: doesn't handle reboot and/or termination requests #72030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dmitshur opened this issue Feb 28, 2025 · 5 comments
Open

x/build/env/freebsd-amd64: doesn't handle reboot and/or termination requests #72030

dmitshur opened this issue Feb 28, 2025 · 5 comments
Assignees
@dmitshur
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-FreeBSD
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Feb 28, 2025 •
edited
Loading

A swarming bot may trigger a reboot or shutdown of a bot running in GCE, a process that involves /sbin/shutdown. See relevant Swarming Bot documentation here:

https://chromium.googlesource.com/infra/luci/luci-py/+/master/appengine/swarming/doc/Bot.md

This seems not to work for freebsd/amd64 builders in GCE. For example, a recent bot had the following history of tasks:

Image

Notably, the bot kept going rather than being terminated.

This process seems to work for openbsd/amd64 builders in GCE.

The difference might be that in the openbsd case the swarming user is given access to execute /sbin/shutdown (here), while the freebsd image might not have taken that or some equivalent measure. There might also be more to it.

CC @golang/release, @golang/freebsd.
@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-FreeBSD labels Feb 28, 2025
@dmitshur dmitshur added this to the Unreleased milestone Feb 28, 2025
@dmitshur dmitshur moved this to Planned in Go Release Mar 12, 2025
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/660756 mentions this issue: env/freebsd-amd64: upgrade to FreeBSD 14.2

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/660977 mentions this issue: main.star: finish upgrading freebsd-amd64 to FreeBSD 14.2

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/660976 mentions this issue: main.star: enable freebsd-amd64_14.2 for x/ repos

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/660975 mentions this issue: main.star: add freebsd-amd64_14.2

@dmitshur dmitshur self-assigned this Mar 26, 2025
@dmitshur dmitshur moved this from Planned to In Progress in Go Release Mar 26, 2025
gopherbot pushed a commit to golang/build that referenced this issue Mar 26, 2025
@dmitshur @gopherbot
main.star: add freebsd-amd64_14.2
16b8cc4 
For golang/go#72030.

Change-Id: Ied0eea6b149867c4b102207436cfd41973ab6a91
Reviewed-on: https://go-review.googlesource.com/c/build/+/660975
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/661535 mentions this issue: env/freebsd-amd64: let swarming user call /sbin/shutdown -r now

gopherbot pushed a commit to golang/build that referenced this issue Mar 28, 2025
@dmitshur @gopherbot
main.star: enable freebsd-amd64_14.2 for x/ repos
f620bc1 
For golang/go#72030.

Change-Id: Id084d31ef87ac3a23fd7ea7153672af4b0d3d4b8
Reviewed-on: https://go-review.googlesource.com/c/build/+/660976
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Mar 28, 2025
@dmitshur @gopherbot
env/freebsd-amd64: upgrade to FreeBSD 14.2
Loading
Loading status checks…
e22abbf 
For golang/go#72030.

Change-Id: I9e8fd0894d8b6dbb24cd68dba11410981152fdf1
Reviewed-on: https://go-review.googlesource.com/c/build/+/660756
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Mar 28, 2025
@dmitshur @gopherbot
env/freebsd-amd64: let swarming user call /sbin/shutdown -r now
Loading
Loading status checks…
15e5891 
One of Swarming Bot requirements is to have passwordless
sudo reboot enabled.

While here, also install unzip for x/build/cmd/racebuild,
and nano for some interactive debugging convenience.

For golang/go#72030.

Change-Id: Ie842a234a61347ee9820ff57ef2a44b050f7367e
Reviewed-on: https://go-review.googlesource.com/c/build/+/661535
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
gopherbot pushed a commit to golang/build that referenced this issue Apr 17, 2025
@dmitshur @gopherbot
main.star: finish upgrading freebsd-amd64 to FreeBSD 14.2
54f8fa3 
FreeBSD 14.2 builders are working okay, so make them the new default.

Keep a minimal number of FreeBSD 14.1 builders (in main Go repo only)
with a known issue to make it easier to test out any further changes.

For golang/go#72030.

Change-Id: Iaa40052ed71d54631f3f6a5b70e90988c7626fef
Reviewed-on: https://go-review.googlesource.com/c/build/+/660977
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitshur dmitshur

Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-FreeBSD
Projects
Go Release
Status: In Progress
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot