Go version

go1.24

Output of go env in your module/workspace:

n/a

What did you do?

Build pulumi with main module version v3.152.0+incompatible+dirty from pulumi project

Such version is not a valid semver as per semver spec & regex, as only a single + suffix allowed; which must be followed by not-dot-character and then additional characters.

What did you see happen?

It creates +incompatible+dirty + vcs.modified=true fields. The +dirty is entirely redundant, no? given that vcs.modified=true already exists to specify +dirty

What did you expect to see?

I expect for the module version to be: v3.152.0+incompatible without +dirty suffix which is already encoded in vcs.modified=true. Or alternatively as +incompatible.dirty see below.

Such that go module version generate still passes the semver spec regex as seen at:
https://github.com/anchore/go-version/blob/main/version.go#L28

Alternatively the identifiers must be dot separated, from https://semver.org/#spec-item-10:

10. Build metadata MAY be denoted by appending a plus sign and a series of dot separated identifiers immediately following the patch or pre-release version. Identifiers MUST comprise only ASCII alphanumerics and hyphens [0-9A-Za-z-]. Identifiers MUST NOT be empty. Build metadata MUST be ignored when determining version precedence. Thus two versions that differ only in the build metadata, have the same precedence. Examples: 1.0.0-alpha+001, 1.0.0+20130313144700, 1.0.0-beta+exp.sha.5114f85, 1.0.0+21AF26D3----117B344092BD.

Thus correct semver with incompatible & dirty build metadata should be: v3.152.0+incompatible.dirty