Skip to content

x/tools/gopls/internal/test/integration/diagnostics: TestSimplifyCompositeLitDiagnostic/default failures #71946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gopherbot opened this issue Feb 25, 2025 · 3 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@gopherbot
Copy link
Contributor

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/diagnostics" && test == "TestSimplifyCompositeLitDiagnostic/default"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestSimplifyCompositeLitDiagnostic/default
    diagnostics_test.go:1317: context deadline exceeded
#### Start Gopls Test Logs for "TestSimplifyCompositeLitDiagnostic/default"
[Trace - 13:27:57.408 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fake.Editor","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":true}},"documentSymbol":{"hierarchicalDocumentSymbolSupport":true},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":[""]}},"dataSupport":true,"resolveSupport":{"properties":["edit"]}},"publishDiagnostics":{},"semanticTokens":{"requests":{"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator","label"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary","interface","struct","signature","pointer","array","map","slice","chan","string","number","bool","invalid"],"formats":null}},"window":{"workDoneProgress":true,"showDocument":{"support":true}}},"initializationOptions":{"completionBudget":"0s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/home/swarming/.swarming/w/ir/x/t/gopls-test-3740751654/TestSimplifyCompositeLitDiagnostic/default/gopath","GOPROXY":"file:///home/swarming/.swarming/w/ir/x/t/gopls-test-3740751654/TestSimplifyCompositeLitDiagnostic/default/proxy","GOSUMDB":"off","GOTOOLCHAIN":"local"},"staticcheck":true,"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///home/swarming/.swarming/w/ir/x/t/gopls-test-3740751654/TestSimplifyCompositeLitDiagnostic/default/work","name":"work"}]}


[Trace - 13:27:57.411 PM] Received response 'initialize - (1)' in 3ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":{"codeActionKinds":["gopls.doc.features","quickfix","refactor.extract.constant","refactor.extract.constant-all","refactor.extract.function","refactor.extract.method","refactor.extract.toNewFile","refactor.extract.variable","refactor.extract.variable-all","refactor.inline.call","refactor.rewrite.changeQuote","refactor.rewrite.fillStruct","refactor.rewrite.fillSwitch","refactor.rewrite.invertIf","refactor.rewrite.joinLines","refactor.rewrite.removeUnusedParam","refactor.rewrite.splitLines","source.assembly","source.doc","source.fixAll","source.freesymbols","source.organizeImports"],"resolveProvider":true},"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.add_telemetry_counters","gopls.add_test","gopls.apply_fix","gopls.assembly","gopls.change_signature","gopls.check_upgrades","gopls.client_open_url","gopls.diagnose_files","gopls.doc","gopls.edit_go_directive","gopls.extract_to_new_file","gopls.fetch_vulncheck_result","gopls.free_symbols","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.maybe_prompt_for_telemetry","gopls.mem_stats","gopls.modules","gopls.package_symbols","gopls.packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_go_work_command","gopls.run_govulncheck","gopls.run_tests","gopls.scan_imports","gopls.start_debugging","gopls.start_profile","gopls.stop_profile","gopls.tidy","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor","gopls.views","gopls.vulncheck","gopls.workspace_stats"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","typeParameter","parameter","variable","function","method","macro","keyword","comment","string","number","operator","label"],"tokenModifiers":["definition","readonly","defaultLibrary","array","bool","chan","format","interface","map","number","pointer","signature","slice","string","struct"]},"range":true,"full":true},"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.24.0-devel_af236716b2308d018e021dc617ab6935459e2b42\",\"Path\":\"golang.org/x/tools/gopls/internal/test/integration/diagnostics.test\",\"Main\":{\"Path\":\"golang.org/x/tools/gopls\",\"Version\":\"(devel)\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":[{\"Key\":\"-buildmode\",\"Value\":\"exe\"},{\"Key\":\"-compiler\",\"Value\":\"gc\"},{\"Key\":\"CGO_ENABLED\",\"Value\":\"1\"},{\"Key\":\"CGO_CFLAGS\",\"Value\":\"\"},{\"Key\":\"CGO_CPPFLAGS\",\"Value\":\"\"},{\"Key\":\"CGO_CXXFLAGS\",\"Value\":\"\"},{\"Key\":\"CGO_LDFLAGS\",\"Value\":\"\"},{\"Key\":\"GOARCH\",\"Value\":\"arm\"},{\"Key\":\"GOOS\",\"Value\":\"netbsd\"},{\"Key\":\"GOARM\",\"Value\":\"7\"}],\"Version\":\"(devel)\"}"}}

...
panic: test timed out after 50m0s
	running tests:
		TestSimplifyCompositeLitDiagnostic (13m54s)
		TestSimplifyCompositeLitDiagnostic/default (13m54s)

goroutine 44727 [running]:
testing.(*M).startAlarm.func1()
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:2484 +0x3a4
created by time.goFunc
	/home/swarming/.swarming/w/ir/x/w/goroot/src/time/sleep.go:215 +0x2c
...
sync.runtime_SemacquireWaitGroup(0x84db1b8)
	/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/sema.go:110 +0x3c
sync.(*WaitGroup).Wait(0x84db1b0)
	/home/swarming/.swarming/w/ir/x/w/goroot/src/sync/waitgroup.go:118 +0x68
golang.org/x/tools/gopls/internal/server.(*server).diagnoseChangedViews(0x96df598, {0x10cef04, 0xef84390}, 0x1, 0x9f62ea0, 0x0)
	/home/swarming/.swarming/w/ir/x/w/targetrepo1004026540/gopls/internal/server/diagnostics.go:173 +0x3e8
golang.org/x/tools/gopls/internal/server.(*server).didModifyFiles.func2()
	/home/swarming/.swarming/w/ir/x/w/targetrepo1004026540/gopls/internal/server/text_synchronization.go:270 +0x54
created by golang.org/x/tools/gopls/internal/server.(*server).didModifyFiles in goroutine 43013
	/home/swarming/.swarming/w/ir/x/w/targetrepo1004026540/gopls/internal/server/text_synchronization.go:269 +0x438

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 25, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/diagnostics" && test == "TestSimplifyCompositeLitDiagnostic/default"
2025-02-24 17:19 x_tools-go1.24-netbsd-arm tools@d2fcd360 release-branch.go1.24@af236716 x/tools/gopls/internal/test/integration/diagnostics.TestSimplifyCompositeLitDiagnostic/default [ABORT] (log)
=== RUN   TestSimplifyCompositeLitDiagnostic/default
    diagnostics_test.go:1317: context deadline exceeded
#### Start Gopls Test Logs for "TestSimplifyCompositeLitDiagnostic/default"
[Trace - 13:27:57.408 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fake.Editor","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":true}},"documentSymbol":{"hierarchicalDocumentSymbolSupport":true},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":[""]}},"dataSupport":true,"resolveSupport":{"properties":["edit"]}},"publishDiagnostics":{},"semanticTokens":{"requests":{"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator","label"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary","interface","struct","signature","pointer","array","map","slice","chan","string","number","bool","invalid"],"formats":null}},"window":{"workDoneProgress":true,"showDocument":{"support":true}}},"initializationOptions":{"completionBudget":"0s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/home/swarming/.swarming/w/ir/x/t/gopls-test-3740751654/TestSimplifyCompositeLitDiagnostic/default/gopath","GOPROXY":"file:///home/swarming/.swarming/w/ir/x/t/gopls-test-3740751654/TestSimplifyCompositeLitDiagnostic/default/proxy","GOSUMDB":"off","GOTOOLCHAIN":"local"},"staticcheck":true,"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///home/swarming/.swarming/w/ir/x/t/gopls-test-3740751654/TestSimplifyCompositeLitDiagnostic/default/work","name":"work"}]}


[Trace - 13:27:57.411 PM] Received response 'initialize - (1)' in 3ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":{"codeActionKinds":["gopls.doc.features","quickfix","refactor.extract.constant","refactor.extract.constant-all","refactor.extract.function","refactor.extract.method","refactor.extract.toNewFile","refactor.extract.variable","refactor.extract.variable-all","refactor.inline.call","refactor.rewrite.changeQuote","refactor.rewrite.fillStruct","refactor.rewrite.fillSwitch","refactor.rewrite.invertIf","refactor.rewrite.joinLines","refactor.rewrite.removeUnusedParam","refactor.rewrite.splitLines","source.assembly","source.doc","source.fixAll","source.freesymbols","source.organizeImports"],"resolveProvider":true},"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.add_telemetry_counters","gopls.add_test","gopls.apply_fix","gopls.assembly","gopls.change_signature","gopls.check_upgrades","gopls.client_open_url","gopls.diagnose_files","gopls.doc","gopls.edit_go_directive","gopls.extract_to_new_file","gopls.fetch_vulncheck_result","gopls.free_symbols","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.maybe_prompt_for_telemetry","gopls.mem_stats","gopls.modules","gopls.package_symbols","gopls.packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_go_work_command","gopls.run_govulncheck","gopls.run_tests","gopls.scan_imports","gopls.start_debugging","gopls.start_profile","gopls.stop_profile","gopls.tidy","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor","gopls.views","gopls.vulncheck","gopls.workspace_stats"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","typeParameter","parameter","variable","function","method","macro","keyword","comment","string","number","operator","label"],"tokenModifiers":["definition","readonly","defaultLibrary","array","bool","chan","format","interface","map","number","pointer","signature","slice","string","struct"]},"range":true,"full":true},"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.24.0-devel_af236716b2308d018e021dc617ab6935459e2b42\",\"Path\":\"golang.org/x/tools/gopls/internal/test/integration/diagnostics.test\",\"Main\":{\"Path\":\"golang.org/x/tools/gopls\",\"Version\":\"(devel)\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":[{\"Key\":\"-buildmode\",\"Value\":\"exe\"},{\"Key\":\"-compiler\",\"Value\":\"gc\"},{\"Key\":\"CGO_ENABLED\",\"Value\":\"1\"},{\"Key\":\"CGO_CFLAGS\",\"Value\":\"\"},{\"Key\":\"CGO_CPPFLAGS\",\"Value\":\"\"},{\"Key\":\"CGO_CXXFLAGS\",\"Value\":\"\"},{\"Key\":\"CGO_LDFLAGS\",\"Value\":\"\"},{\"Key\":\"GOARCH\",\"Value\":\"arm\"},{\"Key\":\"GOOS\",\"Value\":\"netbsd\"},{\"Key\":\"GOARM\",\"Value\":\"7\"}],\"Version\":\"(devel)\"}"}}

...
panic: test timed out after 50m0s
	running tests:
		TestSimplifyCompositeLitDiagnostic (13m54s)
		TestSimplifyCompositeLitDiagnostic/default (13m54s)

goroutine 44727 [running]:
testing.(*M).startAlarm.func1()
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:2484 +0x3a4
created by time.goFunc
	/home/swarming/.swarming/w/ir/x/w/goroot/src/time/sleep.go:215 +0x2c
...
sync.runtime_SemacquireWaitGroup(0x84db1b8)
	/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/sema.go:110 +0x3c
sync.(*WaitGroup).Wait(0x84db1b0)
	/home/swarming/.swarming/w/ir/x/w/goroot/src/sync/waitgroup.go:118 +0x68
golang.org/x/tools/gopls/internal/server.(*server).diagnoseChangedViews(0x96df598, {0x10cef04, 0xef84390}, 0x1, 0x9f62ea0, 0x0)
	/home/swarming/.swarming/w/ir/x/w/targetrepo1004026540/gopls/internal/server/diagnostics.go:173 +0x3e8
golang.org/x/tools/gopls/internal/server.(*server).didModifyFiles.func2()
	/home/swarming/.swarming/w/ir/x/w/targetrepo1004026540/gopls/internal/server/text_synchronization.go:270 +0x54
created by golang.org/x/tools/gopls/internal/server.(*server).didModifyFiles in goroutine 43013
	/home/swarming/.swarming/w/ir/x/w/targetrepo1004026540/gopls/internal/server/text_synchronization.go:269 +0x438

watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 25, 2025
@gopherbot gopherbot added this to the Unreleased milestone Feb 25, 2025
@adonovan
Copy link
Member

More netbsd stuckness.

cc: @golang/netbsd

@adonovan adonovan moved this to Active in Test Flakes Feb 28, 2025
@findleyr
Copy link
Member

Given that this is an arbitrary builder issue, I don't think it's worth holding this issue open: probably nothing specific to this test.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Mar 19, 2025
@github-project-automation github-project-automation bot moved this from Active to Done in Test Flakes Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Status: Done
Development

No branches or pull requests

3 participants