Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: temporarily reinstate the 'Structured' hoverkind. #71880

Closed
findleyr opened this issue Feb 21, 2025 · 2 comments
Closed

x/tools/gopls: temporarily reinstate the 'Structured' hoverkind. #71880

findleyr opened this issue Feb 21, 2025 · 2 comments
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.18.1

Comments

@findleyr
Copy link
Member

Unfortunately, our audit of usage of the misguided experimental "structured" hoverkind setting failed to identify that vim-go used it, and we bypassed our normal probationary period for removing settings.

We should add this setting back until dependent clients can be updated, with a warning and telemetry.

FWIW, vim-go was using Structured.

Originally posted by @bhcleek in #70233
@findleyr findleyr added this to the gopls/v0.18.1 milestone Feb 21, 2025
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 21, 2025
@findleyr findleyr mentioned this issue Feb 21, 2025
Closed
@findleyr
Copy link
Member Author

Argh, I failed to add json struct tags in the partial revert. Reopening.

@findleyr findleyr reopened this Feb 21, 2025
@findleyr
Copy link
Member Author

(reopened wrong issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.18.1
Development

No branches or pull requests
2 participants
@gopherbot @findleyr