Skip to content

cmd/compile: Pow10 freeze the compiler on certain condition on Go 1.24 [1.24 backport] #71855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Feb 20, 2025 · 3 comments
Closed

cmd/compile: Pow10 freeze the compiler on certain condition on Go 1.24 [1.24 backport] #71855

gopherbot opened this issue Feb 20, 2025 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.24.1

Comments

@gopherbot
Copy link
Contributor

@Jorropo requested issue #71852 to be considered for backport to the next 1.24 minor release.

@gopherbot Please open backport issue for 1.24

This is a regression where non esoteric code that used to build now does not.
https://gophers.slack.com/archives/C6CM8NUEB/p1740060033459149
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 20, 2025
@gopherbot gopherbot mentioned this issue Feb 20, 2025
Closed
@Jorropo Jorropo added this to the Go1.24.1 milestone Feb 20, 2025
@Jorropo
Copy link
Member

Jorropo commented Feb 20, 2025 •
edited
Loading

I've submitted two different proper fixes:

We merged the simple 2 sloc fix.

My original plan to revert 820f58a would not solve all regression cases, just the particular one discovered in #71852.

~~I think the only correct revert would involve reverting most of @randall77's prove constants handling improvements, so I think we should consider backporting the fix altho this is more risky~~ edit: the previous implementation has known bugs that were fixed in this refactor like #67625. I don't think that relevant to bring this up anymore.
If rather than backporting, we could revert 3b96eeb which would be very messy and require reverting more commits than I have fingers.

@Jorropo Jorropo changed the title math: Pow10 freeze the compiler on certain condition on Go 1.24 [1.24 backport] cmd/compile: Pow10 freeze the compiler on certain condition on Go 1.24 [1.24 backport] Feb 20, 2025
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Feb 20, 2025
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/652179 mentions this issue: [release-branch.go1.24] cmd/compile: don't report newLimit discovered when unsat happens multiple times

@prattmic prattmic added the CherryPickApproved Used during the release process for point releases label Feb 26, 2025
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Feb 26, 2025
gopherbot pushed a commit that referenced this issue Feb 26, 2025
@Jorropo @prattmic
[release-branch.go1.24] cmd/compile: don't report newLimit discovered…

Verified

This commit was signed with the committer’s verified signature. The key has expired.
rodneyrehm Rodney Rehm
GPG key ID: C41EC19BFD2CA905
Expired
Verified
Learn about vigilant mode
456eaf5 
… when unsat happens multiple times

Fixes #71855

Change-Id: I696fcb8fc8c0c2e5e5ae6ab50596f6bdb9b7d498
Reviewed-on: https://go-review.googlesource.com/c/go/+/650975
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
(cherry picked from commit 00635de)
Reviewed-on: https://go-review.googlesource.com/c/go/+/652179
Reviewed-by: Jorropo <jorropo.pgm@gmail.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
@gopherbot
Copy link
Contributor Author

Closed by merging CL 652179 (commit 456eaf5) to release-branch.go1.24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.24.1
Development

No branches or pull requests
4 participants
@prattmic @gopherbot @Jorropo and others