Skip to content

crypto: add fips140 as an opaque GODEBUG setting and add documentation for it [1.24 backport] #71745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Feb 14, 2025 · 3 comments
Closed

crypto: add fips140 as an opaque GODEBUG setting and add documentation for it [1.24 backport] #71745

gopherbot opened this issue Feb 14, 2025 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases
Milestone
Go1.24.1

Comments

@gopherbot
Copy link
Contributor

@FiloSottile requested issue #71666 to be considered for backport to the next 1.24 minor release.

Ah, I didn't realize if it's not in godebugs.All it wouldn't be available from go.mod and source files, that was definitely not intended, good catch.

@gopherbot please open a backport issue for Go 1.24. We should probably backport https://go.dev/cl/649495 to fix that, and I think https://go.dev/cl/648520 so it will show up at https://go.dev/doc/godebug?
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 14, 2025
@gopherbot gopherbot mentioned this issue Feb 14, 2025
Closed
@gopherbot gopherbot added this to the Go1.24.1 milestone Feb 14, 2025
@gopherbot gopherbot added the Documentation Issues describing a change to documentation. label Feb 14, 2025
@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases Documentation Issues describing a change to documentation. labels Feb 19, 2025
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/650596 mentions this issue: [release-branch.go1.24] doc/godebug: mention GODEBUG=fips140

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/650675 mentions this issue: [release-branch.go1.24] internal/godebugs: add fips140 as an opaque godebug setting

@dmitshur dmitshur changed the title crypto: no documentation for GODEBUG=fips140 [1.24 backport] crypto: add fips140 as an opaque GODEBUG setting and add documentation for it [1.24 backport] Feb 19, 2025
gopherbot pushed a commit that referenced this issue Feb 19, 2025
@ianlancetaylor @gopherbot
[release-branch.go1.24] doc/godebug: mention GODEBUG=fips140
0f7b760 
For #71666
For #71745

Change-Id: Ice816cf2943c5b6660f05934b4c7ca38545714b0
Reviewed-on: https://go-review.googlesource.com/c/go/+/648520
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Commit-Queue: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
(cherry picked from commit 5f65e5c)
Reviewed-on: https://go-review.googlesource.com/c/go/+/650596
Reviewed-by: Michael Knyszek <mknyszek@google.com>
@gopherbot
Copy link
Contributor Author

Closed by merging CL 650596 (commit 0f7b760) to release-branch.go1.24.

gopherbot pushed a commit that referenced this issue Feb 26, 2025
@ianlancetaylor @gopherbot
[release-branch.go1.24] internal/godebugs: add fips140 as an opaque g…
f5c3883 
…odebug setting

This permits using "godebug fips140=on" in go.mod and
using "//go:debug fips140=on" in the main package.

Change code references to the godebug setting to remove the #
which is no longer required.

For #71666
Fixes #71745

Change-Id: I3a60ecc55b03848dadd6d431eb43137b6df6568b
Reviewed-on: https://go-review.googlesource.com/c/go/+/649495
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
(cherry picked from commit 2b43ce0a9d5825d66aa42a6fa9076f2fb9c181ea)
Reviewed-on: https://go-review.googlesource.com/c/go/+/650675
Commit-Queue: Ian Lance Taylor <iant@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases
Projects
None yet
Milestone
Go1.24.1
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot