Skip to content

x/tools/gopls/internal/test/marker: empty output from go command causes flaky tests #71670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Feb 11, 2025 · 5 comments
Closed

x/tools/gopls/internal/test/marker: empty output from go command causes flaky tests #71670

gopherbot opened this issue Feb 11, 2025 · 5 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/codeaction/addtest.txt"

Issue created automatically to collect these failures.

Example (log):

=== RUN   Test/codeaction/addtest.txt
=== PAUSE Test/codeaction/addtest.txt
=== CONT  Test/codeaction/addtest.txt

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 11, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/codeaction/addtest.txt"
2025-02-11 21:34 x_tools-gotip-freebsd-amd64-race tools@b3c5d108 go@102406ed x/tools/gopls/internal/test/marker.Test/codeaction/addtest.txt [ABORT] (log) 
=== RUN   Test/codeaction/addtest.txt
=== PAUSE Test/codeaction/addtest.txt
=== CONT  Test/codeaction/addtest.txt

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 11, 2025
@gopherbot gopherbot added this to the Unreleased milestone Feb 11, 2025
@adonovan
Copy link
Member

adonovan commented Feb 12, 2025 •
edited
Loading

This is another case of empty stdout from the go command. We already have an open issue for test flakes due to this cause, but I am currently unable to find it.

[Update: I was thinking of https://github.com//issues/71215, but that's specific to netbsd.]

@adonovan adonovan changed the title x/tools/gopls/internal/test/marker: Test/codeaction/addtest.txt failures x/tools/gopls/internal/test/marker: empty output from go command causes flaky tests Feb 13, 2025
@jba
Copy link
Contributor

jba commented Feb 13, 2025

Spurious timeout.

@jba jba closed this as completed Feb 13, 2025
@jba jba closed this as not planned Won't fix, can't repro, duplicate, stale Feb 13, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/codeaction/addtest.txt"
2025-02-19 23:52 x_tools-gotip-freebsd-amd64-race tools@300465cc go@266b0cff x/tools/gopls/internal/test/marker.Test/codeaction/addtest.txt [ABORT] (log) 
=== RUN   Test/codeaction/addtest.txt
=== PAUSE Test/codeaction/addtest.txt
=== CONT  Test/codeaction/addtest.txt

— watchflakes

@gopherbot gopherbot reopened this Feb 20, 2025
@github-project-automation github-project-automation bot moved this from Done to Active in Test Flakes Feb 20, 2025
@findleyr
Copy link
Member

Another timeout...

@github-project-automation github-project-automation bot moved this from Active to Done in Test Flakes Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@adonovan @gopherbot @jba @findleyr