Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: Rename: missing type for selector in satisfy.(*Finder).expr #71657

Open
adonovan opened this issue Feb 11, 2025 · 6 comments
Open

x/tools/gopls: Rename: missing type for selector in satisfy.(*Finder).expr #71657

adonovan opened this issue Feb 11, 2025 · 6 comments
Labels
BugReport Issues describing a possible bug in the Go implementation. gopls/telemetry-wins gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/backlog

Comments

@adonovan
Copy link
Member

adonovan commented Feb 11, 2025 •
edited
Loading 

#!stacks
"runtime.sigpanic" && "satisfy.(*Finder).expr:+75"

Issue created by stacks.

	case *ast.SelectorExpr:
		if _, ok := f.info.Selections[e]; ok {
			f.expr(e.X) // selection
		} else {
			return f.info.Uses[e.Sel].Type() // qualified identifier                 <----------- panic 
		}

This is related to #71572 and #73109: satisfy was called on ill-typed code; and the resolution is the same: wait for #70638.

This stack kscqug was reported by telemetry:

golang.org/x/tools/gopls@v0.17.1 go1.23.2 darwin/arm64 vscode (1)

Dups: bgW9pQ aibuLA aJ9H_w x0Q4yQ 7x8J4g
@adonovan adonovan added gopls Issues related to the Go language server, gopls. gopls/telemetry-wins NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. labels Feb 11, 2025
@gopherbot gopherbot added this to the Unreleased milestone Feb 11, 2025
@gabyhelp
Copy link

Related Issues

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@gabyhelp gabyhelp mentioned this issue Feb 11, 2025
Open
@gabyhelp gabyhelp added the BugReport Issues describing a possible bug in the Go implementation. label Feb 11, 2025
@jba
Copy link
Contributor

jba commented Feb 13, 2025

Although this issue is in the gopls/backlog milestone, it belongs in the hypothetical milestone "first gopls release after the next Go release (1.25)," since the next Go release should have implemented #70638.

@adonovan
Copy link
Member Author

This stack bgW9pQ was reported by telemetry:

golang.org/x/tools/gopls@v0.17.1 go1.23.4 darwin/arm64 other,vscode (1)

@adonovan
Copy link
Member Author

This stack aibuLA was reported by telemetry:

golang.org/x/tools/gopls@v0.17.1 go1.23.3 linux/amd64 vscode (1)

@adonovan
Copy link
Member Author

This stack aJ9H_w was reported by telemetry:

golang.org/x/tools/gopls@v0.18.1 go1.24.0 darwin/arm64 vscode (1)

@adonovan
Copy link
Member Author

This stack x0Q4yQ was reported by telemetry:

golang.org/x/tools/gopls@v0.18.1 go1.24.0 windows/amd64 other,vscode (2)

This stack 7x8J4g was reported by telemetry:

golang.org/x/tools/gopls@v0.18.1 go1.24.0 windows/amd64 other,vscode (1)

@adonovan adonovan mentioned this issue Mar 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BugReport Issues describing a possible bug in the Go implementation. gopls/telemetry-wins gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/backlog
Development

No branches or pull requests
4 participants
@adonovan @gopherbot @jba @gabyhelp