Skip to content

unicode/utf8: Test constants duplicates check in init #71579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
krmpotic opened this issue Feb 6, 2025 · 3 comments
Closed

unicode/utf8: Test constants duplicates check in init #71579

krmpotic opened this issue Feb 6, 2025 · 3 comments
Labels
BugReport Issues describing a possible bug in the Go implementation. NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.25

Comments

@krmpotic
Copy link
Contributor

krmpotic commented Feb 6, 2025 •
edited
Loading

utf8_test.init
utf8_test.TestConstants

I think either a comment why the double test is necessary should be there, or one removed.
@seankhliao seankhliao changed the title duplication of code needs explanation unicode/utf8: Test constants duplicates check in init Feb 6, 2025
@gabyhelp gabyhelp added the BugReport Issues describing a possible bug in the Go implementation. label Feb 6, 2025
@randall77
Copy link
Contributor

I think the init portion is old. It does not exist in unicode/utf16, for example.
Feel free to send a pull request to delete it.

@krmpotic krmpotic mentioned this issue Feb 6, 2025
Closed
@krmpotic
Copy link
Contributor Author

krmpotic commented Feb 6, 2025 •
edited
Loading

PR: #71582

@krmpotic krmpotic closed this as completed Feb 6, 2025
@krmpotic krmpotic reopened this Feb 6, 2025
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/647335 mentions this issue: unicode/utf8: remove init from utf8_test

krmpotic added a commit to krmpotic/go that referenced this issue Feb 6, 2025
@krmpotic
unicode/utf8: remove test's init function
d7224c1 
TestConstants and init test the same thing, remove init,
it does not exist in utf16_test.go either.

Fixes golang#71579
@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Feb 7, 2025
@dmitshur dmitshur added this to the Go1.25 milestone Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BugReport Issues describing a possible bug in the Go implementation. NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.25
Development

Successfully merging a pull request may close this issue.

unicode/utf8: remove init from utf8_test krmpotic/go
5 participants
@dmitshur @randall77 @gopherbot @krmpotic @gabyhelp