Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log/syslog: flakey TestConcurrentReconnect test #7146

Closed
mikioh opened this issue Jan 18, 2014 · 2 comments
Closed

log/syslog: flakey TestConcurrentReconnect test #7146

mikioh opened this issue Jan 18, 2014 · 2 comments
Labels
FrozenDueToAge
Milestone
Unplanned

Comments

@mikioh
Copy link
Contributor

mikioh commented Jan 18, 2014 

What steps will reproduce the problem?
1. go test -v -run=TestConcurrentReconnect -cpu=2,2,2,2
2.
3.

What is the expected output? What do you see instead?
PASS: TestConcurrentReconnect-2 (0.07 seconds)

Please use labels and text to provide additional information.
http://build.golang.org/log/d8b466031c5eabeaf15e7d63dca7554c99504920
http://build.golang.org/log/016f140e757cfe8cf2516d74cb898351fec8df24
http://build.golang.org/log/abd6c0a78f68780e03f55c656bd291aa22891661
@mikioh
Copy link
Contributor Author

mikioh commented Jan 18, 2014

Comment 1:

Looks like srvWG.Wait of TestConcurrentReconnect waits forever, sigh, too much
complicated test. The infinite loop might be closed by reading/writing unix-domain
sockets (and thier watermarks) and server/client liveliness checking sync.WaitGroups.

@bradfitz bradfitz removed the new label Dec 18, 2014
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@ysmolski
Copy link
Member

ysmolski commented Nov 6, 2018 •
edited

This seems to be working as intended for netbsd: https://build.golang.org/

Feel free to reopen if I am not correct, @mikioh.

Also on my machine (macos):

..src/log/syslog (master $%=) % go test -v -run=TestConcurrentReconnect -cpu=2,2,2,2
=== RUN   TestConcurrentReconnect
--- PASS: TestConcurrentReconnect (0.01s)
=== RUN   TestConcurrentReconnect
--- PASS: TestConcurrentReconnect (0.00s)
=== RUN   TestConcurrentReconnect
--- PASS: TestConcurrentReconnect (0.00s)
=== RUN   TestConcurrentReconnect
--- PASS: TestConcurrentReconnect (0.00s)
PASS
ok  	log/syslog	0.025s

EDIT: link above.

@ysmolski ysmolski closed this as completed Nov 6, 2018
@golang golang locked and limited conversation to collaborators Nov 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
5 participants
@bradfitz @mikioh @rsc @ysmolski @gopherbot