Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mime/multipart: quoted-printable check is not quote enough #7139

Closed
jmhodges opened this issue Jan 17, 2014 · 3 comments
Closed

mime/multipart: quoted-printable check is not quote enough #7139

jmhodges opened this issue Jan 17, 2014 · 3 comments
Labels
FrozenDueToAge

Comments

@jmhodges
Copy link
Contributor 

I've found emails that are Content-Type: multipart/alternative, but instead of putting
the Content-Transfer-Encoding: quoted-printable in each relevant part's MIME header
section, it puts it in the emails top-level MIME header section.

This makes the check in mime/multipart's newPart function[1] miss the fact that the
reader needs to be wrapped in quotedPrintableReader.

Either we could inherit the Content-Transfer-Encoding from the top-level header when
creating a new Part, or we can expose the quotedPrintableReader struct for users to fix
up.

[1] http://golang.org/src/pkg/mime/multipart/multipart.go#L98
@jmhodges
Copy link
Contributor Author

Comment 1:

Shoot. I am mistaken. These weren't coming in as multipart. They were just plaintext
emails with Content-Transfer-Encoding: quoted-printable. There's just no public
QuotedPrintableReader to reuse. This can be closed in favor of something like #4943.

@jmhodges
Copy link
Contributor Author

Comment 2:

As a mea culpa to people who come across this later, I've taken the QPReader from inside
mime/multipart and pushed it to as github.com/jmhodges/emailenc/quotedprintable. I might
end up adding a q decoder to it as well.

@ianlancetaylor
Copy link
Contributor

Comment 3:

Status changed to Retracted.

@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jmhodges @ianlancetaylor @gopherbot