Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/quic: excess CRYPTO data not cleaned up after keys discarded #70704

Closed
neild opened this issue Dec 5, 2024 · 2 comments
Closed

x/net/quic: excess CRYPTO data not cleaned up after keys discarded #70704

neild opened this issue Dec 5, 2024 · 2 comments
Assignees
Milestone

Comments

@neild
Copy link
Contributor

neild commented Dec 5, 2024

When a CRYPTO frame contains data which results in us discarding packet protection keys for a number space, we should verify that we don't have any excess buffered crypto data.

For example, if we receive CRYPTO frames in the Initial space containing bytes 0-100 and 101-200, and the 0-100 segment causes us to drop packet protection keys for the Initial space, the excess data (bytes 101-200) is erroneous and should result in the connection being closed.

(SImplest option here might be to avoid providing data to the TLS stack if we've got any gaps in the CRYPTO stream, and then let the TLS layer complain about receiving too much data.)

@neild neild self-assigned this Dec 5, 2024
@gabyhelp
Copy link

gabyhelp commented Dec 5, 2024

Related Issues

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@gopherbot gopherbot added this to the Unreleased milestone Dec 5, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/634617 mentions this issue: quic: clean up crypto streams when dropping packet protection keys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants