Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/quic: mishandling of ACK frames after space dropped #70703

Closed
neild opened this issue Dec 5, 2024 · 1 comment
Closed

x/net/quic: mishandling of ACK frames after space dropped #70703

neild opened this issue Dec 5, 2024 · 1 comment
Assignees
@neild
Milestone
Unreleased

Comments

@neild
Copy link
Contributor

neild commented Dec 5, 2024

If a single packet contains a CRYPTO frame which results in us dropping state for a packet number space, and contains a subsequent ACK frame, we will incorrectly close the connection with a protocol violation error. The CRYPTO frame drops state for the number space, and the ACK frame is then misinterpreted as acknowledging frames which were not sent.
@gopherbot gopherbot added this to the Unreleased milestone Dec 5, 2024
@neild neild self-assigned this Dec 5, 2024
@gabyhelp gabyhelp mentioned this issue Dec 5, 2024
Closed
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/634616 mentions this issue: quic: handle ACK frame in packet which drops number space

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neild neild

Labels
None yet
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@neild @gopherbot