Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go,x/telemetry/config: collect vcs systems used #70628

Open
seankhliao opened this issue Dec 1, 2024 · 5 comments
Open

cmd/go,x/telemetry/config: collect vcs systems used #70628

seankhliao opened this issue Dec 1, 2024 · 5 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Telemetry-Proposal Issues proposing new telemetry counters.
Milestone

Comments

@seankhliao
Copy link
Member

Summary

I propose we collect a count of whether each vcs system (git, hg, svn, fossil, bzr) was used recently.
I question the continued value of supporting the less used systems (e.g. bazaar, cmd/go special cases launchpad.net, but I believe it has switched primarily to git now).

Proposed Config Change

@seankhliao seankhliao added the Telemetry-Proposal Issues proposing new telemetry counters. label Dec 1, 2024
@mknyszek mknyszek added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 2, 2024
@mknyszek
Copy link
Contributor

mknyszek commented Dec 2, 2024

CC @golang/telemetry

@mknyszek mknyszek added this to the Backlog milestone Dec 2, 2024
@hyangah
Copy link
Contributor

hyangah commented Dec 3, 2024

Alternative way to inspect this is to look into the module info proxy.golang.org see. Recognized vcs kinds are recorded there.

https://proxy.golang.org/golang.org/x/tools/gopls/@v/v0.16.2.info

Limitation of this approach however, is that proxy.golang.org sees only publicly available source code.

@seankhliao
Copy link
Member Author

cmd/go defaults GOVCS to "public:git|hg,private:all". Does the proxy still handle the other vcs systems?

@hyangah
Copy link
Contributor

hyangah commented Dec 3, 2024

cmd/go defaults GOVCS to "public:git|hg,private:all". Does the proxy still handle the other vcs systems?

Yes. proxy.golang.org uses public:all.

@findleyr findleyr moved this to Hold in Telemetry Proposals Apr 1, 2025
@findleyr
Copy link
Member

findleyr commented Apr 1, 2025

We discussed this in the telemetry proposal meeting today. We'd like to put this on hold until there's a concrete proposal to deprecate support for a VCS system. We think the evidence in the proxy is probably sufficient to justify such a proposal, so there is no pressing need for telemetry data.

(And for what it's worth, we are unlikely to prioritize deprecating VCS support any time soon, since it would be a significant project).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Telemetry-Proposal Issues proposing new telemetry counters.
Projects
Development

No branches or pull requests

4 participants