Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: fmt: State Flag(int) should be Flag(rune) #7047

Open
kortschak opened this issue Jan 1, 2014 · 3 comments
Open

proposal: fmt: State Flag(int) should be Flag(rune) #7047

kortschak opened this issue Jan 1, 2014 · 3 comments
Labels
Go2Cleanup Used by Ian and Robert for Go 2 organization. Unless you’re Ian or Robert, please do not use this. v2 A language change or incompatible library change
Milestone

Comments

@kortschak
Copy link
Contributor

This issue is really just a note.

The Flag method of fmt.State takes an int argument but represents a 'character'.
Probably it should have been changed from int to rune when the rune alias was introduced
(or byte - given all flags are ASCII).

Which version are you using?  (run 'go version')

go1.2
@ianlancetaylor
Copy link
Contributor

Comment 1:

Labels changed: added go2.

@minux
Copy link
Member

minux commented Jan 27, 2014

Comment 2:

Labels changed: added repo-main.

@davecheney
Copy link
Contributor

Comment 3:

Labels changed: added release-none.

Status changed to Accepted.

@kortschak kortschak added accepted v2 A language change or incompatible library change labels Jan 31, 2014
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc changed the title fmt: fmt.(State).Flag() takes an int argument fmt: State Flag(int) should be Flag(rune) Jun 17, 2017
@rsc rsc changed the title fmt: State Flag(int) should be Flag(rune) proposal: fmt: State Flag(int) should be Flag(rune) Jun 17, 2017
@ianlancetaylor ianlancetaylor added the Go2Cleanup Used by Ian and Robert for Go 2 organization. Unless you’re Ian or Robert, please do not use this. label Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Go2Cleanup Used by Ian and Robert for Go 2 organization. Unless you’re Ian or Robert, please do not use this. v2 A language change or incompatible library change
Projects
None yet
Development

No branches or pull requests

5 participants