Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/test/integration/codelens: TestUpgradeCodelens_Workspace/Upgrade_transitive_dependencies/default failures #70411

Closed
gopherbot opened this issue Nov 18, 2024 · 4 comments
Closed

x/tools/gopls/internal/test/integration/codelens: TestUpgradeCodelens_Workspace/Upgrade_transitive_dependencies/default failures #70411

gopherbot opened this issue Nov 18, 2024 · 4 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/codelens" && test == "TestUpgradeCodelens_Workspace/Upgrade_transitive_dependencies/default"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestUpgradeCodelens_Workspace/Upgrade_transitive_dependencies/default
--- FAIL: TestUpgradeCodelens_Workspace/Upgrade_transitive_dependencies/default (451.92s)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 18, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/codelens" && test == "TestUpgradeCodelens_Workspace/Upgrade_transitive_dependencies/default"
2024-10-08 22:13 x_tools-go1.22-windows-amd64-race tools@cf8979b7 release-branch.go1.22@29252e4c x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens_Workspace/Upgrade_transitive_dependencies/default (log) 
=== RUN   TestUpgradeCodelens_Workspace/Upgrade_transitive_dependencies/default
--- FAIL: TestUpgradeCodelens_Workspace/Upgrade_transitive_dependencies/default (451.92s)

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 18, 2024
@gopherbot gopherbot added this to the Unreleased milestone Nov 18, 2024
@findleyr
Copy link
Member

Hanging go command.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Nov 18, 2024
@gopherbot gopherbot reopened this Jan 6, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/codelens" && test == "TestUpgradeCodelens_Workspace/Upgrade_transitive_dependencies/default"
2025-01-03 21:39 x_tools-go1.23-windows-amd64-longtest tools@43ba4651 release-branch.go1.23@1576793c x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens_Workspace/Upgrade_transitive_dependencies/default (log) 
=== RUN   TestUpgradeCodelens_Workspace/Upgrade_transitive_dependencies/default
goroutine profile: total 12
1 @ 0x9f4751 0xa34cfd 0xbd8671 0xbd84a5 0xbd52cb 0x14d2c30 0x14d2887 0xb1b9eb 0xa3ec81
#	0xbd8670	runtime/pprof.writeRuntimeProfile+0xb0						C:/b/s/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:793
#	0xbd84a4	runtime/pprof.writeGoroutine+0x44						C:/b/s/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:752
#	0xbd52ca	runtime/pprof.(*Profile).WriteTo+0x14a						C:/b/s/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:374
#	0x14d2c2f	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1.1+0x6f	C:/b/s/w/ir/x/w/targetrepo2238866553/gopls/internal/test/integration/runner.go:198
#	0x14d2886	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1+0x986	C:/b/s/w/ir/x/w/targetrepo2238866553/gopls/internal/test/integration/runner.go:240
#	0xb1b9ea	testing.tRunner+0xca								C:/b/s/w/ir/x/w/goroot/src/testing/testing.go:1690

...
#	0x11b667c	golang.org/x/tools/internal/imports.(*ProcessEnv).GetResolver+0x1fc		C:/b/s/w/ir/x/w/targetrepo2238866553/internal/imports/fix.go:1036
#	0x12a7f75	golang.org/x/tools/gopls/internal/cache.(*importsState).refreshProcessEnv+0xd5	C:/b/s/w/ir/x/w/targetrepo2238866553/gopls/internal/cache/imports.go:233
#	0x12a70a1	golang.org/x/tools/gopls/internal/cache.(*refreshTimer).schedule.func1+0xc1	C:/b/s/w/ir/x/w/targetrepo2238866553/gopls/internal/cache/imports.go:73

1 @ 0xa35eee 0xa3a3b7 0xdcfd65 0xa3ec81
#	0xa3a3b6	time.Sleep+0xf6						C:/b/s/w/ir/x/w/goroot/src/runtime/time.go:300
#	0xdcfd64	golang.org/x/tools/gopls/internal/filecache.gc+0x124	C:/b/s/w/ir/x/w/targetrepo2238866553/gopls/internal/filecache/filecache.go:457

    runner.go:199: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: <nil>; removing files: remove C:\b\s\w\ir\x\t\gopls-test-1835137369\TestUpgradeCodelens_Workspace\Upgrade_transitive_dependencies\default\gopath\pkg\mod\cache\download\golang.org\x\hello\@v: The directory is not empty.
--- FAIL: TestUpgradeCodelens_Workspace/Upgrade_transitive_dependencies/default (33.41s)

— watchflakes

@github-project-automation github-project-automation bot moved this from Done to Active in Test Flakes Jan 6, 2025
@findleyr
Copy link
Member

"Directory not empty"

Not sure why this test in particular runs into these rare flakes. 🤔

@github-project-automation github-project-automation bot moved this from Active to Done in Test Flakes Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@gopherbot @findleyr