Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/test/integration/codelens: TestUpgradeCodelens_Workspace/Upgrade_transitive_dependencies/default failures #70382

Closed
gopherbot opened this issue Nov 15, 2024 · 3 comments
Closed

x/tools/gopls/internal/test/integration/codelens: TestUpgradeCodelens_Workspace/Upgrade_transitive_dependencies/default failures #70382

gopherbot opened this issue Nov 15, 2024 · 3 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/codelens" && test == "TestUpgradeCodelens_Workspace/Upgrade_transitive_dependencies/default"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestUpgradeCodelens_Workspace/Upgrade_transitive_dependencies/default
--- FAIL: TestUpgradeCodelens_Workspace/Upgrade_transitive_dependencies/default (451.92s)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 15, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/codelens" && test == "TestUpgradeCodelens_Workspace/Upgrade_transitive_dependencies/default"
2024-10-08 22:13 x_tools-go1.22-windows-amd64-race tools@cf8979b7 release-branch.go1.22@29252e4c x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens_Workspace/Upgrade_transitive_dependencies/default (log) 
=== RUN   TestUpgradeCodelens_Workspace/Upgrade_transitive_dependencies/default
--- FAIL: TestUpgradeCodelens_Workspace/Upgrade_transitive_dependencies/default (451.92s)

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 15, 2024
@gopherbot gopherbot added this to the Unreleased milestone Nov 15, 2024
@findleyr
Copy link
Member

findleyr commented Nov 18, 2024 •
edited
Loading

Hanging Go command -- dupe of #54461. @cherrymui any idea why this didn't match the watchflakes predicate of that issue? It appears to me that it should have matched.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Nov 18, 2024
@findleyr findleyr removed this from Test Flakes Nov 18, 2024
@cherrymui
Copy link
Member

watchflakes currently has a heuristic that when a top-level test and its subtest fail, it picks the subtest, which is usually where the specific failure is. But in this case the "hanging go command" appears on the top-level test. Perhaps it should pick the one with the longer output?

#54461 also has log ~ detected hanging go command, which should match the textual log of the entire run, which does contain the message. Not sure why that doesn't match. I can look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@gopherbot @cherrymui @findleyr