Skip to content

x/tools/gopls/internal/test/integration/misc: TestRunVulncheckPackageDiagnostics/imports/default failures #70347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gopherbot opened this issue Nov 14, 2024 · 3 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@gopherbot
Copy link
Contributor

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/misc" && test == "TestRunVulncheckPackageDiagnostics/imports/default"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestRunVulncheckPackageDiagnostics/imports/default
panic: jsonrpc2.Async called multiple times

goroutine 79001 [running]:
golang.org/x/tools/internal/jsonrpc2.(*releaser).release(0x400ab625b8, 0xe0?)
	/home/swarming/.swarming/w/ir/x/w/targetrepo3594206611/internal/jsonrpc2/handler.go:147 +0xf8
golang.org/x/tools/internal/jsonrpc2.Async({0xfb6a88?, 0x40147fd0e0?})
	/home/swarming/.swarming/w/ir/x/w/targetrepo3594206611/internal/jsonrpc2/handler.go:122 +0x58
golang.org/x/tools/gopls/internal/server.(*commandHandler).RunGovulncheck.func1({0xfb6a88, 0x40147fd0e0}, {0x40086acc60?, {0xfb9340?, 0x400b518720?}, 0x40147fd180?})
	/home/swarming/.swarming/w/ir/x/w/targetrepo3594206611/gopls/internal/server/command.go:1316 +0x9c
golang.org/x/tools/gopls/internal/server.(*commandHandler).run.func2()
	/home/swarming/.swarming/w/ir/x/w/targetrepo3594206611/gopls/internal/server/command.go:381 +0x80
golang.org/x/tools/gopls/internal/server.(*commandHandler).run.func3()
	/home/swarming/.swarming/w/ir/x/w/targetrepo3594206611/gopls/internal/server/command.go:405 +0x40
created by golang.org/x/tools/gopls/internal/server.(*commandHandler).run in goroutine 79000
	/home/swarming/.swarming/w/ir/x/w/targetrepo3594206611/gopls/internal/server/command.go:404 +0x394

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 14, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/misc" && test == "TestRunVulncheckPackageDiagnostics/imports/default"
2024-11-14 15:14 x_tools-gotip-netbsd-arm64 tools@5b5d57c8 go@80d306da x/tools/gopls/internal/test/integration/misc.TestRunVulncheckPackageDiagnostics/imports/default [ABORT] (log)
=== RUN   TestRunVulncheckPackageDiagnostics/imports/default
panic: jsonrpc2.Async called multiple times

goroutine 79001 [running]:
golang.org/x/tools/internal/jsonrpc2.(*releaser).release(0x400ab625b8, 0xe0?)
	/home/swarming/.swarming/w/ir/x/w/targetrepo3594206611/internal/jsonrpc2/handler.go:147 +0xf8
golang.org/x/tools/internal/jsonrpc2.Async({0xfb6a88?, 0x40147fd0e0?})
	/home/swarming/.swarming/w/ir/x/w/targetrepo3594206611/internal/jsonrpc2/handler.go:122 +0x58
golang.org/x/tools/gopls/internal/server.(*commandHandler).RunGovulncheck.func1({0xfb6a88, 0x40147fd0e0}, {0x40086acc60?, {0xfb9340?, 0x400b518720?}, 0x40147fd180?})
	/home/swarming/.swarming/w/ir/x/w/targetrepo3594206611/gopls/internal/server/command.go:1316 +0x9c
golang.org/x/tools/gopls/internal/server.(*commandHandler).run.func2()
	/home/swarming/.swarming/w/ir/x/w/targetrepo3594206611/gopls/internal/server/command.go:381 +0x80
golang.org/x/tools/gopls/internal/server.(*commandHandler).run.func3()
	/home/swarming/.swarming/w/ir/x/w/targetrepo3594206611/gopls/internal/server/command.go:405 +0x40
created by golang.org/x/tools/gopls/internal/server.(*commandHandler).run in goroutine 79000
	/home/swarming/.swarming/w/ir/x/w/targetrepo3594206611/gopls/internal/server/command.go:404 +0x394

watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 14, 2024
@gopherbot gopherbot added this to the Unreleased milestone Nov 14, 2024
@adonovan
Copy link
Member

Dup of #70355

@adonovan adonovan closed this as not planned Won't fix, can't repro, duplicate, stale Nov 15, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/misc" && test == "TestRunVulncheckPackageDiagnostics/imports/default"
2024-11-14 17:27 x_tools-go1.23-netbsd-arm tools@a8d0fa56 release-branch.go1.23@c390a1c2 x/tools/gopls/internal/test/integration/misc.TestRunVulncheckPackageDiagnostics/imports/default [ABORT] (log)
=== RUN   TestRunVulncheckPackageDiagnostics/imports/default
panic: jsonrpc2.Async called multiple times

goroutine 69967 [running]:
golang.org/x/tools/internal/jsonrpc2.(*releaser).release(0xc90ede0, 0x0)
	/home/swarming/.swarming/w/ir/x/w/targetrepo2540425003/internal/jsonrpc2/handler.go:147 +0xb0
golang.org/x/tools/internal/jsonrpc2.Async({0x102c04c, 0xbc93980})
	/home/swarming/.swarming/w/ir/x/w/targetrepo2540425003/internal/jsonrpc2/handler.go:122 +0x58
golang.org/x/tools/gopls/internal/server.(*commandHandler).RunGovulncheck.func1({0x102c04c, 0xbc93980}, {0xe7708c8, {0x102c7dc, 0xe90a0c0}, 0xbc939e0})
	/home/swarming/.swarming/w/ir/x/w/targetrepo2540425003/gopls/internal/server/command.go:1316 +0x98
golang.org/x/tools/gopls/internal/server.(*commandHandler).run.func2()
	/home/swarming/.swarming/w/ir/x/w/targetrepo2540425003/gopls/internal/server/command.go:381 +0xa0
golang.org/x/tools/gopls/internal/server.(*commandHandler).run.func3()
	/home/swarming/.swarming/w/ir/x/w/targetrepo2540425003/gopls/internal/server/command.go:405 +0x38
created by golang.org/x/tools/gopls/internal/server.(*commandHandler).run in goroutine 69980
	/home/swarming/.swarming/w/ir/x/w/targetrepo2540425003/gopls/internal/server/command.go:404 +0x43c

watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Archived in project
Development

No branches or pull requests

2 participants