-
Notifications
You must be signed in to change notification settings - Fork 18k
x/tools/gopls/internal/test/integration/misc: TestShowDocumentUnsupported/supported=false/default failures #70342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Found new dashboard test flakes for:
2024-11-13 23:15 x_tools-go1.22-windows-386 tools@025b8122 release-branch.go1.22@8af39d30 x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
|
My new test. Must be racy. Looking. |
Found new dashboard test flakes for:
2024-11-14 15:14 x_tools-go1.22-windows-amd64-longtest tools@5b5d57c8 release-branch.go1.22@8af39d30 x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
|
D'oh, it took a while for me to see it, but there's actually no synchronization of notifications and responses on the client stream: responses are concurrent to notifications, so any test that asserts we got a notification in the process of handling a request is technically racy. This definitely was not my mental model, and we have a number of tests that are structured in this way. I suspect the race is very hard to reach in practice, I checked and it appears jsonrpc2_v2 has the same behavior, so this wouldn't be fixed by the upgrade. Will ponder a fix. |
Found new dashboard test flakes for:
2024-11-13 23:15 x_tools-go1.23-netbsd-arm64 tools@025b8122 release-branch.go1.23@c390a1c2 x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
2024-11-14 15:42 x_tools-gotip-darwin-amd64_11 tools@47a5f7d1 go@8e714281 x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
|
Change https://go.dev/cl/627696 mentions this issue: |
Found new dashboard test flakes for:
2024-11-14 15:14 x_tools-go1.22-netbsd-arm64 tools@5b5d57c8 release-branch.go1.22@8af39d30 x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
2024-11-14 15:14 x_tools-go1.23-linux-riscv64 tools@5b5d57c8 release-branch.go1.23@c390a1c2 x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
2024-11-14 17:27 x_tools-go1.23-windows-amd64-race tools@a8d0fa56 release-branch.go1.23@c390a1c2 x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
2024-11-14 19:09 x_tools-gotip-linux-ppc64_power10 tools@b4332e09 go@672a53de x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
2024-11-14 19:09 x_tools-go1.22-darwin-amd64_12 tools@8bb5da33 release-branch.go1.22@8af39d30 x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
2024-11-14 19:09 x_tools-go1.22-windows-386 tools@8bb5da33 release-branch.go1.22@8af39d30 x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
2024-11-14 19:09 x_tools-go1.22-windows-amd64 tools@8bb5da33 release-branch.go1.22@8af39d30 x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
2024-11-14 19:09 x_tools-gotip-linux-ppc64_power8 tools@8bb5da33 go@672a53de x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
|
Found new dashboard test flakes for:
2024-11-14 19:13 x_tools-gotip-darwin-amd64-race tools@221e94d0 go@672a53de x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
|
Found new dashboard test flakes for:
2024-11-13 23:15 x_tools-gotip-netbsd-arm tools@025b8122 go@673a5391 x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
2024-11-14 17:27 x_tools-go1.22-netbsd-arm64 tools@a8d0fa56 release-branch.go1.22@8af39d30 x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
2024-11-14 19:13 x_tools-go1.23-darwin-amd64-longtest tools@221e94d0 release-branch.go1.23@c390a1c2 x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
|
Found new dashboard test flakes for:
2024-11-14 15:14 x_tools-go1.22-netbsd-arm tools@5b5d57c8 release-branch.go1.22@8af39d30 x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
|
Found new dashboard test flakes for:
2024-11-14 19:13 x_tools-go1.22-netbsd-arm64 tools@221e94d0 release-branch.go1.22@8af39d30 x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
2024-11-14 19:13 x_tools-gotip-linux-ppc64_power8 tools@221e94d0 go@672a53de x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
2024-11-14 23:37 x_tools-go1.22-windows-386 tools@c043599d release-branch.go1.22@8af39d30 x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
2024-11-14 23:37 x_tools-go1.23-windows-amd64 tools@c043599d release-branch.go1.23@c390a1c2 x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
|
Found new dashboard test flakes for:
2024-11-14 19:09 x_tools-go1.23-darwin-amd64-race tools@b4332e09 release-branch.go1.23@c390a1c2 x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
|
Found new dashboard test flakes for:
2024-11-14 19:13 x_tools-go1.23-linux-riscv64 tools@221e94d0 release-branch.go1.23@c390a1c2 x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
|
Found new dashboard test flakes for:
2024-11-14 19:44 x_tools-go1.22-netbsd-arm tools@3c20e3f6 release-branch.go1.22@8af39d30 x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
|
Found new dashboard test flakes for:
2024-11-14 23:37 x_tools-go1.23-netbsd-arm tools@29f4edbc release-branch.go1.23@c390a1c2 x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
|
Found new dashboard test flakes for:
2024-11-14 19:09 x_tools-gotip-netbsd-arm64 tools@8bb5da33 go@493edb29 x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
|
Found new dashboard test flakes for:
2024-11-14 15:42 x_tools-gotip-netbsd-arm64 tools@47a5f7d1 go@493edb29 x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
|
Found new dashboard test flakes for:
2024-11-14 19:13 x_tools-go1.22-netbsd-arm tools@84e9c336 release-branch.go1.22@8af39d30 x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
|
Found new dashboard test flakes for:
2024-11-14 19:09 x_tools-go1.22-netbsd-arm tools@8bb5da33 release-branch.go1.22@8af39d30 x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
|
Found new dashboard test flakes for:
2024-11-15 16:16 x_tools-gotip-netbsd-arm64 tools@254baba6 go@63f762bc x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
|
Found new dashboard test flakes for:
2024-11-15 16:16 x_tools-go1.22-netbsd-arm64 tools@254baba6 release-branch.go1.22@8af39d30 x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
|
Found new dashboard test flakes for:
2024-11-15 16:16 x_tools-go1.22-netbsd-arm tools@254baba6 release-branch.go1.22@8af39d30 x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
|
Found new dashboard test flakes for:
2024-11-14 15:14 x_tools-gotip-freebsd-amd64 tools@5b5d57c8 go@d31d77a2 x/tools/gopls/internal/test/integration/misc.TestShowDocumentUnsupported/supported=false/default (log)
|
Issue created automatically to collect these failures.
Example (log):
— watchflakes
The text was updated successfully, but these errors were encountered: