Skip to content

time: TestLoadFixed failures [1.22 backport] #70238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Nov 7, 2024 · 3 comments
Closed

time: TestLoadFixed failures [1.22 backport] #70238

gopherbot opened this issue Nov 7, 2024 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.22.10

Comments

@gopherbot
Copy link
Contributor

@ianlancetaylor requested issue #69840 to be considered for backport to the next 1.22 minor release.

@gopherbot Please open backport issues.

This test failure is due to a change in the tzdata files on OpenBSD. We should either backport the (trivial) fix or have some other way to ignore the test failure on the builders.
@gopherbot gopherbot added CherryPickCandidate Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure. labels Nov 7, 2024
@gopherbot gopherbot mentioned this issue Nov 7, 2024
Closed
@gopherbot gopherbot added this to the Go1.22.10 milestone Nov 7, 2024
@cherrymui
Copy link
Member

Test only fix, to make it work with newer OpenBSD. Approved.

@cherrymui cherrymui added the CherryPickApproved Used during the release process for point releases label Nov 13, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Nov 13, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/627416 mentions this issue: [release-branch.go1.22] time: accept "+01" in TestLoadFixed on OpenBSD

@gopherbot
Copy link
Contributor Author

Closed by merging CL 627416 (commit 3355db9) to release-branch.go1.22.

gopherbot pushed a commit that referenced this issue Nov 19, 2024
@dmitshur @gopherbot
[release-branch.go1.22] time: accept "+01" in TestLoadFixed on OpenBSD

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
3355db9 
This stops the test from failing with a known failure mode, and
creates time to look into what the next steps should be, if any.

For #69840.
Fixes #70238.

Change-Id: I060903d256ed65c5dfcd70ae76eb361cab63186f
Reviewed-on: https://go-review.googlesource.com/c/go/+/625197
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Eric Grosse <grosse@gmail.com>
(cherry picked from commit bea9b91)
Reviewed-on: https://go-review.googlesource.com/c/go/+/627416
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Commit-Queue: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.22.10
Development

No branches or pull requests
2 participants
@gopherbot @cherrymui