Related Issues and Documentation

• x/tools/gopls: handle undefined struct type in `undeclaredname` autofix code action #69947
• x/tools/gopls: feature: offer quickfix for variable name that is incorrectly initialized #69980
• x/tools/gopls: multiple "Fill anonymous struct" quick fixes are confusing #48563 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

Sure, that seems like a reasonable feature.

great, I will start the implementation taking the issue I mentioned into account as an example.
I didn't investigate the codebase deep enough, but the plan is the following:

• I handle the same message "has no field or method"
• define a struct field info and pass this message to the code action
• define a fixer and apply it

I couldn't find a similar GetCallStubInfo for structs, if Im just seeking poorly pls let me know

I handle the same message "has no field or method"

There is probably another case to consider:

f := Foo{
    a: 3, // unknown field a in struct literal of type Foo
}

This can be one more case for TypesFromContext, I've add
more in golang/tools#538, maybe you can
take a look.

@xzbdmw thanks, would be useful to extract the type properly.
I will rebase on your branch then.
I anticipate we should create another issue for unknown field, will do as soon as finish with this, because half of the solution can be reused.

@dennypenta You don’t need to rebase! I will rebase on yours if your cl merge first :)

folks, I dare to ask a couple things since Im a first time contributor.

• must a PR have 0 merge conflicts? mine has one constantly due to change logs
• is there a proper way to ask for a attention?
  I have no response for a couple months and guess I do something wrong.

folks, I dare to ask a couple things since Im a first time contributor.
must a PR have 0 merge conflicts? mine has one constantly due to change logs

In order to be merged, yes, there must be no conflicts. But we can review your code if the conflicts are minor.

is there a proper way to ask for a attention?

Pinging this issue (as you did) is effective.

I have no response for a couple months and guess I do something wrong.

We don't use GitHub PRs; instead we review CLs in Gerrit, which has much better ergonomics. I wasn't aware of the PR at all; I guess it uses GitHub notifications, which I must have suppressed because they are too numerous. There is a robot that causes GitHub PRs to be mirrored as Gerrit CLs (your CL is https://go.dev/cl/628877) but since none of the team were named as reviewers it didn't come to our attention. Now that it has, I will take a look at your code.