Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: memory corruption when setting outer values in functional iterators [1.23 backport] #70198

Closed
gopherbot opened this issue Nov 5, 2024 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone

Comments

@gopherbot
Copy link
Contributor

@randall77 requested issue #70035 to be considered for backport to the next 1.23 minor release.

Probably.
@gopherbot Please open a backport issue to 1.23.

This causes a serious miscompilation in certain range-over-func situations.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Nov 5, 2024
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Nov 5, 2024
@gopherbot gopherbot added this to the Go1.23.3 milestone Nov 5, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/625535 mentions this issue: [release-branch.go1.23] cmd/compile: use a non-fragile test for "does f contain closure c?"

@dr2chase dr2chase added the CherryPickApproved Used during the release process for point releases label Nov 6, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Nov 6, 2024
@gopherbot gopherbot modified the milestones: Go1.23.3, Go1.23.4 Nov 6, 2024
gopherbot pushed a commit that referenced this issue Nov 19, 2024
… f contain closure c?"

The old test relied on naming conventions.  The new test
uses an explicit parent pointer chain initialized when the
closures are created (in the same place that the names
used in the older fragile test were assigned).

Fixes #70198.

Change-Id: Ie834103c7096e4505faaff3bed1fc6e918a21211
Reviewed-on: https://go-review.googlesource.com/c/go/+/622656
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/625535
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
@gopherbot
Copy link
Contributor Author

Closed by merging CL 625535 (commit 3726f07) to release-branch.go1.23.

jrouzierinverse added a commit to inverse-inc/packetfence that referenced this issue Dec 11, 2024
JeGoi added a commit to inverse-inc/packetfence that referenced this issue Dec 11, 2024
Update go version because of golang/go#70198
mpminardi pushed a commit to tailscale/go that referenced this issue Jan 28, 2025
… f contain closure c?"

The old test relied on naming conventions.  The new test
uses an explicit parent pointer chain initialized when the
closures are created (in the same place that the names
used in the older fragile test were assigned).

Fixes golang#70198.

Change-Id: Ie834103c7096e4505faaff3bed1fc6e918a21211
Reviewed-on: https://go-review.googlesource.com/c/go/+/622656
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/625535
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Development

No branches or pull requests

2 participants