Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: data race in BenchmarkServerHijack #7006

Closed
dvyukov opened this issue Dec 23, 2013 · 2 comments
Closed

net/http: data race in BenchmarkServerHijack #7006

dvyukov opened this issue Dec 23, 2013 · 2 comments

Comments

@dvyukov
Copy link
Member

dvyukov commented Dec 23, 2013

ThreadSanitizer says:

WARNING: DATA RACE
Write by goroutine 374:
  net/http_test.BenchmarkServerHijack()
      src/pkg/net/http/serve_test.go:2413 +0x34d
  testing.(*B).runN()
      src/pkg/testing/benchmark.go:119 +0xc0
  testing.(*B).launch()
      src/pkg/testing/benchmark.go:207 +0x1ba

Previous read by goroutine 110:
  net/http_test.(*oneConnListener).Accept()
      src/pkg/net/http/serve_test.go:42 +0x59
  net/http.(*Server).Serve()
      src/pkg/net/http/server.go:1618 +0xa1
  net/http.Serve()
      src/pkg/net/http/server.go:1557 +0xac

Goroutine 374 (running) created at:
  testing.(*B).run()
      src/pkg/testing/benchmark.go:170 +0x3c
  testing.RunBenchmarks()
      src/pkg/testing/benchmark.go:303 +0x6ba
  testing.Main()
      src/pkg/testing/testing.go:411 +0x216
  main.main()
      /tmp/builder/go-build794329701/net/http/_test/_testmain.go:425 +0xdc

Goroutine 110 (finished) created at:
  net/http_test.BenchmarkServerHijack()
      src/pkg/net/http/serve_test.go:2414 +0x419
  testing.(*B).runN()
      src/pkg/testing/benchmark.go:119 +0xc0
  testing.(*B).launch()
      src/pkg/testing/benchmark.go:207 +0x1ba

http://build.golang.org/log/3de092081861c2a60d12cb21a264c24566d5e57c
@bradfitz
Copy link
Contributor

Comment 1:

https://golang.org/cl/44940044

Status changed to Started.

@bradfitz
Copy link
Contributor

Comment 2:

This issue was closed by revision 1fa0206.

Status changed to Fixed.

@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants