Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/link: Use of --build-id broke solaris-amd64 bot #70031

Closed
rorth opened this issue Oct 24, 2024 · 4 comments
Closed

cmd/link: Use of --build-id broke solaris-amd64 bot #70031

rorth opened this issue Oct 24, 2024 · 4 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done. OS-Solaris
Milestone
Go1.24

Comments

@rorth
Copy link

rorth commented Oct 24, 2024

Go version

go version devel go1.24-4646556ba4 Thu Oct 24 12:32:56 2024 +0000 solaris/amd64

Output of go env in your module/workspace:

GO111MODULE=''
GOARCH='amd64'
GOAUTH='netrc'
GOBIN=''
GOCACHE='/homes/ro/.xdg/SunOS/.cache/go-build'
GOENV='/homes/ro/.xdg/SunOS/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='solaris'
GOINSECURE=''
GOMODCACHE='/homes/ro/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='solaris'
GOPATH='/homes/ro/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/var/gcc/go/goroot'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/var/gcc/go/goroot/pkg/tool/solaris_amd64'
GOVCS=''
GOVERSION='devel go1.24-4646556ba4 Thu Oct 24 12:32:56 2024 +0000'
GODEBUG=''
GOTELEMETRY='local'
GOTELEMETRYDIR='/homes/ro/.xdg/SunOS/.config/go/telemetry'
GCCGO='/usr/bin/gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/var/gcc/go/goroot/src/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build3829558414=/tmp/go-build -gno-record-gcc-switches'

What did you do?

The solaris-amd64 bot has been broken for a couple of days. I could trace this to this commit

commit 427d1a23ef8183a4e0c6714e391f53d35c614c4d
Author: Cherry Mui <cherryyz@google.com>
Date:   Tue Oct 8 17:59:29 2024 -0400

    cmd/link: on ELF, generate GNU build ID by default

The issue is that while Solaris is ELF, it doesn't use GNU ld but the native linker, thus --build-id isn't supported at al, breaking
the builds. Obviously nobody cared.

What did you see happen?

I see errors like

FAIL    cmd/cgo/internal/test [build failed]
# cmd/cgo/internal/testtls.test
/var/gcc/go/goroot/pkg/tool/solaris_amd64/link: running gcc failed: exit status 1
/usr/bin/gcc -m64 -s -Wl,--build-id=0x8c1abdc141d16b258558487f535944db4fa14cf8 -o $WORK/b2033/testtls.test -rdynamic -Wl,--compress-debug-sections=zlib /tmp/go-link-666226246/go.o /tmp/go-link-666226246/000000.o /tmp/go-link-666226246/000001.o /tmp/go-link-666226246/000002.o /tmp/go-link-666226246/000003.o /tmp/go-link-666226246/000004.o /tmp/go-link-666226246/000005.o /tmp/go-link-666226246/000006.o /tmp/go-link-666226246/000007.o /tmp/go-link-666226246/000008.o /tmp/go-link-666226246/000009.o /tmp/go-link-666226246/000010.o /tmp/go-link-666226246/000011.o /tmp/go-link-666226246/000012.o -O2 -g -lsendfile -O2 -g -lxnet -lsocket -no-pie
ld: fatal: unrecognized option --build-id=0x8c1abdc141d16b258558487f535944db4fa14cf8
ld: fatal: use the '-z help' option for usage information
collect2: error: ld returned 1 exit status

What did you expect to see?

The build should complete without errors, as it has before. AFAICS, all other uses of --build-id properly guard the use of that
option, restricting it to targets that are known to support it. This patch ignores that precedent, going by the unwarranted (and proven wrong) assumption that every ELF target has it.
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Oct 24, 2024
@gabyhelp
Copy link

Related Issues and Documentation

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@ianlancetaylor
Copy link
Member

The fix is https://go.dev/cl/621639.

@ianlancetaylor
Copy link
Member

Which is now merged.

@dmitshur dmitshur added this to the Go1.24 milestone Oct 24, 2024
@dmitshur dmitshur added OS-Solaris NeedsFix The path to resolution is known, but the work has not been done. labels Oct 24, 2024
@rorth
Copy link
Author

rorth commented Oct 28, 2024

Thanks for the quick fix. Two questions, though:

  • The 15c5580 commit message says 
      On Solaris the default (non-GNU) C linker doesn't support the
  --build-id flag (and I'm not aware of any alternative). So check
  that the linker supports the flag before passing it.
    This is not true: while the bundled /usr/bin/gcc is configured to use /usr/bin/ld and install.texi recommends that, it is also possible to configure with GNU ld (and that configuration is regularly tested).
  • Right now there are four cases where the Go sources use --build-id, however with a different guard in every case: 
    cmd/link/internal/ld/lib.go
cmd/link/elf_test.go
cmd/go/internal/work/gccgo.go
cmd/go/internal/work/exec.go
    I wonder if they shouldn't be unified?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done. OS-Solaris
Projects
None yet
Milestone
Go1.24
Development

No branches or pull requests
5 participants
@dmitshur @ianlancetaylor @rorth @gopherbot @gabyhelp