Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime/pprof: some tests fail when run with -race flag on windows #6986

Closed
alexbrainman opened this issue Dec 19, 2013 · 3 comments
Closed

runtime/pprof: some tests fail when run with -race flag on windows #6986

alexbrainman opened this issue Dec 19, 2013 · 3 comments
Labels
FrozenDueToAge RaceDetector
Milestone
Go1.3

Comments

@alexbrainman
Copy link
Member 

c:\go\root\src\pkg\runtime\pprof>go test -race -short
--- FAIL: TestCPUProfileMultithreaded (32.32 seconds)
        pprof_test.go:64: profile too short: [0x0 0x3 0x0 0x2710 0x0 0x0 0x1 0x0]
--- FAIL: TestMathBigDivide (5.03 seconds)
        pprof_test.go:64: profile too short: [0x0 0x3 0x0 0x2710 0x0 0x0 0x1 0x0]
FAIL
exit status 1
FAIL    runtime/pprof   55.045s

c:\go\root\src\pkg\runtime\pprof>hg id
0eb7eedf1fc6 tip

Alex

PS: Also note that TestCPUProfileMultithreaded runs for too long.
@bradfitz
Copy link
Contributor

Comment 1:

Labels changed: added release-go1.3.

Status changed to Accepted.

@dvyukov
Copy link
Member

dvyukov commented Dec 19, 2013

Comment 2:

The linux race builder also episodically fails on this test:
--- FAIL: TestCPUProfileMultithreaded (29.88 seconds)
    pprof_test.go:134: crc32.ChecksumIEEE: 103
    pprof_test.go:134: crc32.Update: 638
    pprof_test.go:144: crc32.ChecksumIEEE has 103 samples out of 741, want at least 123, ideally 370
http://build.golang.org/log/94c53ee2a81070b0ea3ad8d56ca89b456687b54d
http://build.golang.org/log/1aaa561746dfa948ff34ed50f30a9109451efd74

@dvyukov
Copy link
Member

dvyukov commented Jan 22, 2014

Comment 3:

This issue was closed by revision 8a3c587.

Status changed to Fixed.

@rsc rsc added this to the Go1.3 milestone Apr 14, 2015
@rsc rsc removed the release-go1.3 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge RaceDetector
Projects
None yet
Milestone
Go1.3
Development

No branches or pull requests
5 participants
@bradfitz @rsc @dvyukov @gopherbot @alexbrainman