Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: test failure #6970

Closed
robpike opened this issue Dec 16, 2013 · 2 comments
Closed

net/http: test failure #6970

robpike opened this issue Dec 16, 2013 · 2 comments

Comments

@robpike
Copy link
Contributor

robpike commented Dec 16, 2013

hg at changeset:   18604:5118124bb019 on OS X 10.9 running amd64

the net/http tests fail always. they print the cookie errors (they're expected), then
sit quietly for several minutes and then generate several megabytes of stack dump.
here's the first few hundred lines:

tubenose=% go test
2013/12/16 15:34:59 net/http: invalid Cookie.Domain "wrong;bad.abc"; dropping
domain attribute
2013/12/16 15:34:59 net/http: invalid Cookie.Domain "bad-.abc"; dropping
domain attribute
2013/12/16 15:34:59 net/http: invalid Cookie.Domain "::1"; dropping domain
attribute
2013/12/16 15:34:59 net/http: invalid byte ' ' in Cookie.Value; dropping invalid bytes
2013/12/16 15:34:59 net/http: invalid byte '\x00' in Cookie.Value; dropping invalid bytes
2013/12/16 15:34:59 net/http: invalid byte '"' in Cookie.Value; dropping invalid
bytes
2013/12/16 15:34:59 net/http: invalid byte ';' in Cookie.Path; dropping invalid bytes
--- FAIL: TestStressSurpriseServerCloses (7.11 seconds)
    transport_test.go:449: presumed deadlock; no HTTP client activity seen in awhile
    z_last_test.go:96: Test appears to have leaked a timing out dial:
        net.runtime_pollWait(0x917ed0, 0x77, 0x0)
            /Users/r/go/src/pkg/runtime/netpoll.goc:116 +0x6a
        net.(*pollDesc).Wait(0xc21089e290, 0x77, 0x9140c0, 0x24)
            /Users/r/go/src/pkg/net/fd_poll_runtime.go:81 +0x34
        net.(*pollDesc).WaitWrite(0xc21089e290, 0x24, 0x9140c0)
            /Users/r/go/src/pkg/net/fd_poll_runtime.go:90 +0x30
        net.(*netFD).connect(0xc21089e230, 0x0, 0x0, 0x917ea8, 0xc2102c1680, ...)
            /Users/r/go/src/pkg/net/fd_unix.go:86 +0x1c4
        net.(*netFD).dial(0xc21089e230, 0x917e58, 0x0, 0x917e58, 0xc2109e31e0, ...)
            /Users/r/go/src/pkg/net/sock_posix.go:121 +0x33f
        net.socket(0x3ad8b0, 0x3, 0x2, 0x1, 0x0, ...)
            /Users/r/go/src/pkg/net/sock_posix.go:91 +0x40b
        net.internetSocket(0x3ad8b0, 0x3, 0x917e58, 0x0, 0x917e58, ...)
            /Users/r/go/src/pkg/net/ipsock_posix.go:136 +0x161
        net.dialTCP(0x3ad8b0, 0x3, 0x0, 0xc2109e31e0, 0x0, ...)
            /Users/r/go/src/pkg/net/tcpsock_posix.go:155 +0x12f
        net.dialSingle(0x3ad8b0, 0x3, 0xc2102db727, 0xf, 0x0, ...)
            /Users/r/go/src/pkg/net/dial.go:225 +0x3d8
        net.func·015(0x0, 0x0, 0x0, 0x3ad8b0, 0x3, ...)
            /Users/r/go/src/pkg/net/dial.go:158 +0xde
        net.dial(0x3ad8b0, 0x3, 0x917df0, 0xc2109e31e0, 0x1b9bcb8, ...)
            /Users/r/go/src/pkg/net/fd_unix.go:40 +0x45
        net.(*Dialer).Dial(0x1b9bd58, 0x3ad8b0, 0x3, 0xc2102db727, 0xf, ...)
            /Users/r/go/src/pkg/net/dial.go:165 +0x3e0
        net.Dial(0x3ad8b0, 0x3, 0xc2102db727, 0xf, 0x0, ...)
            /Users/r/go/src/pkg/net/dial.go:138 +0x75
        net/http.(*Transport).dial(0xc2102fb880, 0x3ad8b0, 0x3, 0xc2102db727, 0xf, ...)
            /Users/r/go/src/pkg/net/http/transport.go:401 +0xd4
        net/http.(*Transport).dialConn(0xc2102fb880, 0xc210dbff60, 0xc210a764d0, 0x1, 0x0)
            /Users/r/go/src/pkg/net/http/transport.go:444 +0x6e
        net/http.func·016()
            /Users/r/go/src/pkg/net/http/transport.go:419 +0x3e
        created by net/http.(*Transport).getConn
            /Users/r/go/src/pkg/net/http/transport.go:421 +0x11a
        
        net.runtime_pollWait(0x918020, 0x77, 0x0)
            /Users/r/go/src/pkg/runtime/netpoll.goc:116 +0x6a
        net.(*pollDesc).Wait(0xc210dca840, 0x77, 0x9140c0, 0x24)
            /Users/r/go/src/pkg/net/fd_poll_runtime.go:81 +0x34
        net.(*pollDesc).WaitWrite(0xc210dca840, 0x24, 0x9140c0)
            /Users/r/go/src/pkg/net/fd_poll_runtime.go:90 +0x30
        net.(*netFD).connect(0xc210dca7e0, 0x0, 0x0, 0x917ea8, 0xc210e514a0, ...)
            /Users/r/go/src/pkg/net/fd_unix.go:86 +0x1c4
        net.(*netFD).dial(0xc210dca7e0, 0x917e58, 0x0, 0x917e58, 0xc2108fa330, ...)
            /Users/r/go/src/pkg/net/sock_posix.go:121 +0x33f
        net.socket(0x3ad8b0, 0x3, 0x2, 0x1, 0x0, ...)
            /Users/r/go/src/pkg/net/sock_posix.go:91 +0x40b
        net.internetSocket(0x3ad8b0, 0x3, 0x917e58, 0x0, 0x917e58, ...)
            /Users/r/go/src/pkg/net/ipsock_posix.go:136 +0x161
        net.dialTCP(0x3ad8b0, 0x3, 0x0, 0xc2108fa330, 0x0, ...)
            /Users/r/go/src/pkg/net/tcpsock_posix.go:155 +0x12f
        net.dialSingle(0x3ad8b0, 0x3, 0xc2102db727, 0xf, 0x0, ...)
            /Users/r/go/src/pkg/net/dial.go:225 +0x3d8
        net.func·015(0x0, 0x0, 0x0, 0x3ad8b0, 0x3, ...)
            /Users/r/go/src/pkg/net/dial.go:158 +0xde
        net.dial(0x3ad8b0, 0x3, 0x917df0, 0xc2108fa330, 0x1b3dcb8, ...)
            /Users/r/go/src/pkg/net/fd_unix.go:40 +0x45
        net.(*Dialer).Dial(0x1b3dd58, 0x3ad8b0, 0x3, 0xc2102db727, 0xf, ...)
            /Users/r/go/src/pkg/net/dial.go:165 +0x3e0
        net.Dial(0x3ad8b0, 0x3, 0xc2102db727, 0xf, 0x1d44b, ...)
            /Users/r/go/src/pkg/net/dial.go:138 +0x75
        net/http.(*Transport).dial(0xc2102fb880, 0x3ad8b0, 0x3, 0xc2102db727, 0xf, ...)
            /Users/r/go/src/pkg/net/http/transport.go:401 +0xd4
        net/http.(*Transport).dialConn(0xc2102fb880, 0xc2109027e0, 0xc210fc6930, 0x1, 0x0)
            /Users/r/go/src/pkg/net/http/transport.go:444 +0x6e
        net/http.func·016()
            /Users/r/go/src/pkg/net/http/transport.go:419 +0x3e
        created by net/http.(*Transport).getConn
            /Users/r/go/src/pkg/net/http/transport.go:421 +0x11a
        
        net.runtime_pollWait(0x9180c8, 0x77, 0x0)
            /Users/r/go/src/pkg/runtime/netpoll.goc:116 +0x6a
        net.(*pollDesc).Wait(0xc21089e060, 0x77, 0x9140c0, 0x24)
            /Users/r/go/src/pkg/net/fd_poll_runtime.go:81 +0x34
        net.(*pollDesc).WaitWrite(0xc21089e060, 0x24, 0x9140c0)
            /Users/r/go/src/pkg/net/fd_poll_runtime.go:90 +0x30
        net.(*netFD).connect(0xc21089e000, 0x0, 0x0, 0x917ea8, 0xc2102c15a0, ...)
            /Users/r/go/src/pkg/net/fd_unix.go:86 +0x1c4
        net.(*netFD).dial(0xc21089e000, 0x917e58, 0x0, 0x917e58, 0xc2109e30f0, ...)
            /Users/r/go/src/pkg/net/sock_posix.go:121 +0x33f
        net.socket(0x3ad8b0, 0x3, 0x2, 0x1, 0x0, ...)
            /Users/r/go/src/pkg/net/sock_posix.go:91 +0x40b
        net.internetSocket(0x3ad8b0, 0x3, 0x917e58, 0x0, 0x917e58, ...)
            /Users/r/go/src/pkg/net/ipsock_posix.go:136 +0x161
        net.dialTCP(0x3ad8b0, 0x3, 0x0, 0xc2109e30f0, 0x0, ...)
            /Users/r/go/src/pkg/net/tcpsock_posix.go:155 +0x12f
        net.dialSingle(0x3ad8b0, 0x3, 0xc2102db727, 0xf, 0x0, ...)
            /Users/r/go/src/pkg/net/dial.go:225 +0x3d8
        net.func·015(0x0, 0x0, 0x0, 0x3ad8b0, 0x3, ...)
            /Users/r/go/src/pkg/net/dial.go:158 +0xde
        net.dial(0x3ad8b0, 0x3, 0x917df0, 0xc2109e30f0, 0x1bc1cb8, ...)
            /Users/r/go/src/pkg/net/fd_unix.go:40 +0x45
        net.(*Dialer).Dial(0x1bc1d58, 0x3ad8b0, 0x3, 0xc2102db727, 0xf, ...)
            /Users/r/go/src/pkg/net/dial.go:165 +0x3e0
        net.Dial(0x3ad8b0, 0x3, 0xc2102db727, 0xf, 0x1d44b, ...)
            /Users/r/go/src/pkg/net/dial.go:138 +0x75
        net/http.(*Transport).dial(0xc2102fb880, 0x3ad8b0, 0x3, 0xc2102db727, 0xf, ...)
            /Users/r/go/src/pkg/net/http/transport.go:401 +0xd4
        net/http.(*Transport).dialConn(0xc2102fb880, 0xc210dbfd80, 0xc210e59af0, 0x1, 0x0)
            /Users/r/go/src/pkg/net/http/transport.go:444 +0x6e
        net/http.func·016()
            /Users/r/go/src/pkg/net/http/transport.go:419 +0x3e
        created by net/http.(*Transport).getConn
            /Users/r/go/src/pkg/net/http/transport.go:421 +0x11a
        
        net.runtime_pollWait(0x918170, 0x77, 0x0)
            /Users/r/go/src/pkg/runtime/netpoll.goc:116 +0x6a
        net.(*pollDesc).Wait(0xc210af9ed0, 0x77, 0x9140c0, 0x24)
            /Users/r/go/src/pkg/net/fd_poll_runtime.go:81 +0x34
        net.(*pollDesc).WaitWrite(0xc210af9ed0, 0x24, 0x9140c0)
            /Users/r/go/src/pkg/net/fd_poll_runtime.go:90 +0x30
        net.(*netFD).connect(0xc210af9e70, 0x0, 0x0, 0x917ea8, 0xc2102ad5c0, ...)
            /Users/r/go/src/pkg/net/fd_unix.go:86 +0x1c4
        net.(*netFD).dial(0xc210af9e70, 0x917e58, 0x0, 0x917e58, 0xc210b638a0, ...)
            /Users/r/go/src/pkg/net/sock_posix.go:121 +0x33f
        net.socket(0x3ad8b0, 0x3, 0x2, 0x1, 0x0, ...)
            /Users/r/go/src/pkg/net/sock_posix.go:91 +0x40b
        net.internetSocket(0x3ad8b0, 0x3, 0x917e58, 0x0, 0x917e58, ...)
            /Users/r/go/src/pkg/net/ipsock_posix.go:136 +0x161
        net.dialTCP(0x3ad8b0, 0x3, 0x0, 0xc210b638a0, 0x0, ...)
            /Users/r/go/src/pkg/net/tcpsock_posix.go:155 +0x12f
        net.dialSingle(0x3ad8b0, 0x3, 0xc2102db727, 0xf, 0x0, ...)
            /Users/r/go/src/pkg/net/dial.go:225 +0x3d8
        net.func·015(0x0, 0x0, 0x0, 0x3ad8b0, 0x3, ...)
            /Users/r/go/src/pkg/net/dial.go:158 +0xde
        net.dial(0x3ad8b0, 0x3, 0x917df0, 0xc210b638a0, 0x1b17cb8, ...)
            /Users/r/go/src/pkg/net/fd_unix.go:40 +0x45
        net.(*Dialer).Dial(0x1b17d58, 0x3ad8b0, 0x3, 0xc2102db727, 0xf, ...)
            /Users/r/go/src/pkg/net/dial.go:165 +0x3e0
        net.Dial(0x3ad8b0, 0x3, 0xc2102db727, 0xf, 0x1d44b, ...)
            /Users/r/go/src/pkg/net/dial.go:138 +0x75
        net/http.(*Transport).dial(0xc2102fb880, 0x3ad8b0, 0x3, 0xc2102db727, 0xf, ...)
            /Users/r/go/src/pkg/net/http/transport.go:401 +0xd4
        net/http.(*Transport).dialConn(0xc2102fb880, 0xc210b63600, 0xc2103f7380, 0x1, 0x0)
            /Users/r/go/src/pkg/net/http/transport.go:444 +0x6e
        net/http.func·016()
            /Users/r/go/src/pkg/net/http/transport.go:419 +0x3e
        created by net/http.(*Transport).getConn
            /Users/r/go/src/pkg/net/http/transport.go:421 +0x11a
        
        net.runtime_pollWait(0x918368, 0x77, 0x0)
            /Users/r/go/src/pkg/runtime/netpoll.goc:116 +0x6a
        net.(*pollDesc).Wait(0xc210dcaa70, 0x77, 0x9140c0, 0x24)
            /Users/r/go/src/pkg/net/fd_poll_runtime.go:81 +0x34
        net.(*pollDesc).WaitWrite(0xc210dcaa70, 0x24, 0x9140c0)
            /Users/r/go/src/pkg/net/fd_poll_runtime.go:90 +0x30
        net.(*netFD).connect(0xc210dcaa10, 0x0, 0x0, 0x917ea8, 0xc210e514e0, ...)
            /Users/r/go/src/pkg/net/fd_unix.go:86 +0x1c4
        net.(*netFD).dial(0xc210dcaa10, 0x917e58, 0x0, 0x917e58, 0xc2108fa390, ...)
            /Users/r/go/src/pkg/net/sock_posix.go:121 +0x33f
        net.socket(0x3ad8b0, 0x3, 0x2, 0x1, 0x0, ...)
            /Users/r/go/src/pkg/net/sock_posix.go:91 +0x40b
        net.internetSocket(0x3ad8b0, 0x3, 0x917e58, 0x0, 0x917e58, ...)
            /Users/r/go/src/pkg/net/ipsock_posix.go:136 +0x161
        net.dialTCP(0x3ad8b0, 0x3, 0x0, 0xc2108fa390, 0x0, ...)
            /Users/r/go/src/pkg/net/tcpsock_posix.go:155 +0x12f
        net.dialSingle(0x3ad8b0, 0x3, 0xc2102db727, 0xf, 0x0, ...)
            /Users/r/go/src/pkg/net/dial.go:225 +0x3d8
        net.func·015(0x0, 0x0, 0x0, 0x3ad8b0, 0x3, ...)
            /Users/r/go/src/pkg/net/dial.go:158 +0xde
        net.dial(0x3ad8b0, 0x3, 0x917df0, 0xc2108fa390, 0x1bd7cb8, ...)
            /Users/r/go/src/pkg/net/fd_unix.go:40 +0x45
        net.(*Dialer).Dial(0x1bd7d58, 0x3ad8b0, 0x3, 0xc2102db727, 0xf, ...)
            /Users/r/go/src/pkg/net/dial.go:165 +0x3e0
        net.Dial(0x3ad8b0, 0x3, 0xc2102db727, 0xf, 0x1d44b, ...)
            /Users/r/go/src/pkg/net/dial.go:138 +0x75
        net/http.(*Transport).dial(0xc2102fb880, 0x3ad8b0, 0x3, 0xc2102db727, 0xf, ...)
            /Users/r/go/src/pkg/net/http/transport.go:401 +0xd4
        net/http.(*Transport).dialConn(0xc2102fb880, 0xc2109028a0, 0xc210fc6770, 0x1, 0x0)
            /Users/r/go/src/pkg/net/http/transport.go:444 +0x6e
        net/http.func·016()
            /Users/r/go/src/pkg/net/http/transport.go:419 +0x3e
        created by net/http.(*Transport).getConn
            /Users/r/go/src/pkg/net/http/transport.go:421 +0x11a
@bradfitz
Copy link
Contributor

Comment 1:

I can't reproduce.  Same hg id, same OS X version, amd64, etc.

@robpike
Copy link
Contributor Author

robpike commented Dec 17, 2013

Comment 2:

Rebooting the machine made the problem disappear.

Status changed to Invalid.

@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants