Skip to content

x/website: linux install instruction version number not updated on chromeos #69603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RyanRosario opened this issue Sep 24, 2024 · 8 comments
Closed

x/website: linux install instruction version number not updated on chromeos #69603

RyanRosario opened this issue Sep 24, 2024 · 8 comments
Labels
NeedsFix The path to resolution is known, but the work has not been done. website
Milestone
Unreleased

Comments

@RyanRosario
Copy link

What is the URL of the page with the issue?

https://go.dev/doc/install

What is your user agent?

Mozilla/5.0 (X11; CrOS x86_64 14541.0.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/127.0.0.0 Safari/537.36

Screenshot

Screenshot 2024-09-23 7 29 09 PM

What did you do?

I tried to blindly run the command in the first box after downloading the 1.23 go distribution.

What did you see happen?

I got a a no such file or directory error.

Even though the latest version is printed on the blue button, the instructions contained an old version number.

What did you expect to see?

I expected the command to delete any old Go distributions and extract the latest distribution into /usr/local.

I expected the command to contain a version number matching the latest version in the blue button text.
@gopherbot gopherbot added this to the Unreleased milestone Sep 24, 2024
@gabyhelp
Copy link

Related Issues and Documentation

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@seankhliao seankhliao changed the title x/pkgsite: Incorrect version number in installation instructions x/website: update version number in installation commands Sep 25, 2024
@dr2chase
Copy link
Contributor

@golang/tools-team

@dr2chase dr2chase added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 26, 2024
@matloob
Copy link
Contributor

matloob commented Sep 26, 2024 •
edited
Loading

@RyanRosario do you have javascript disabled on your browser?

The filename in the instructions served in the original html is for a 1.14.3 archive but we use javascript to dynamically update the file name in the download instructions.

@hyangah hyangah added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Oct 3, 2024
@RyanRosario
Copy link
Author

@matloob I do not. JavaScript is enabled. I am using Chrome on a Chromebook+. I just visited the site again and it still shows 1.14.3.

@seankhliao
Copy link
Member

Maybe ChomeOS / CrOS should be treated as a unix in https://go.dev/doc/download.js

@seankhliao seankhliao removed the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Oct 6, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/620556 mentions this issue: _content/doc: treat ChromeOS as linux in download selector

@seankhliao seankhliao changed the title x/website: update version number in installation commands x/website: linux install instruction version number not updated on chromeos Oct 16, 2024
@matloob
Copy link
Contributor

matloob commented Oct 17, 2024

I'm wondering why we don't always set the version even if the OS isn't linux? It seems like this problem could occur if the user user agent doesn't match any of the detectOS patterns because the linux tab will be selected by default but the file name won't be updated because the OS isn't set to linux.

@seankhliao
Copy link
Member

I was also wondering why there was a unix OS that wouldn't match any download option. I've updated my CL.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done. website
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
8 participants
@dmitshur @dr2chase @hyangah @RyanRosario @gopherbot @seankhliao @matloob @gabyhelp