Skip to content

x/build/cmd/gomote: don't duplicate logic present in golangbuild in the repro subcommand #69599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mknyszek opened this issue Sep 23, 2024 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@mknyszek
Copy link
Contributor

Soon, gomote repro is going to assume some logic in golangbuild as part of its test command output, specifically for the no-network builders. This is unfortunate, since we're duplicating this subtle logic in multiple places.

Let's strive to avoid that in the future. In particular, test execution in golangbuild has some complexity around test execution. The two biggest ones are disabling the network on some builders and copying nested submodules out of context to test them (#34352). It would make sense to turn golangbuild into its own reproducer, like we do for the environment. This could work but needs thought.

For now, this issue tracks this particular consequence of the complexity of test execution seeping into other parts of the codebase: duplicating the no-network logic for printing the test command in the gomote repro command.

@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Sep 23, 2024
@gopherbot gopherbot added this to the Unreleased milestone Sep 23, 2024
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 24, 2024
@dmitshur
Copy link
Contributor

CC @golang/release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Status: No status
Development

No branches or pull requests

3 participants