x/build/cmd/gomote: don't duplicate logic present in golangbuild in the repro subcommand #69599
Labels
Builders
x/build issues (builders, bots, dashboards)
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Soon,
gomote repro
is going to assume some logic ingolangbuild
as part of its test command output, specifically for the no-network builders. This is unfortunate, since we're duplicating this subtle logic in multiple places.Let's strive to avoid that in the future. In particular, test execution in
golangbuild
has some complexity around test execution. The two biggest ones are disabling the network on some builders and copying nested submodules out of context to test them (#34352). It would make sense to turngolangbuild
into its own reproducer, like we do for the environment. This could work but needs thought.For now, this issue tracks this particular consequence of the complexity of test execution seeping into other parts of the codebase: duplicating the no-network logic for printing the test command in the
gomote repro
command.The text was updated successfully, but these errors were encountered: