Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: perf fails to upload some benchmark data from c3h88 builders #69594

Closed
mknyszek opened this issue Sep 23, 2024 · 1 comment
Closed
Assignees
Labels
Builders x/build issues (builders, bots, dashboards)
Milestone

Comments

@mknyszek
Copy link
Contributor

We're currently missing data for some commits due to failures like

numerator/denominator mismatch, expected 7c72dc77a934cf5957e5667e204506a61457e66a/69234ded30614a471c35cef5d87b0e0d3c136cd9 got 7c72dc77a934cf5957e5667e204506a61457e66a/

when uploading to Influx. This is a failure in the comparison code.

@mknyszek mknyszek self-assigned this Sep 23, 2024
@mknyszek mknyszek added this to the Unreleased milestone Sep 23, 2024
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Sep 23, 2024
@mknyszek
Copy link
Contributor Author

Fixed with the switch to using benchstat's internals for comparison.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards)
Projects
None yet
Development

No branches or pull requests

2 participants