Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/go/ssa: TestTypeparamTest/metrics.go failures #69409

Closed
gopherbot opened this issue Sep 11, 2024 · 3 comments
Closed

x/tools/go/ssa: TestTypeparamTest/metrics.go failures #69409

gopherbot opened this issue Sep 11, 2024 · 3 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@gopherbot
Copy link
Contributor

#!watchflakes
default <- pkg == "golang.org/x/tools/go/ssa" && test == "TestTypeparamTest/metrics.go"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestTypeparamTest/metrics.go
    builder_test.go:805: Input: /home/swarming/.swarming/w/ir/x/w/goroot/test/typeparam/metrics.go
runtime: marked free object in span 0x1cacd00, elemsize=64 freeindex=0 (bad use of unsafe.Pointer? try -d=checkptr)
0x10b00000 free  marked   zombie
0x0000000010b00000:  0x0000000000000004  0x0000000000137fb0 
0x0000000010b00010:  0x000000000eaa2ba0  0x0000000000136ef8 
0x0000000010b00020:  0x00000000004cdbc0  0x0000000000139040 
0x0000000010b00030:  0x00000000004c12a0  0x0000000000000000 
0x10b00040 free  unmarked
0x10b00080 free  unmarked
...
fatal error: found pointer to free object

goroutine 1486 gp=0x20ae540 m=0 mp=0x4d9a60 [running]:
runtime.throw({0xb8a4e, 0x1c})
	/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/panic.go:1023 +0x3 fp=0x185e6e8 sp=0x185e6c0 pc=0x128a0003
runtime.(*mspan).reportZombies(0x1cacd00)
	/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/mgcsweep.go:875 +0x61 fp=0x185e758 sp=0x185e6e8 pc=0x11b40061
runtime.(*sweepLocked).sweep(0x185e8b0, 0x0)
	/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/mgcsweep.go:638 +0x7a fp=0x185e878 sp=0x185e758 pc=0x11af007a
runtime.sweepone()
...
golang.org/x/tools/go/ssa_test.TestTypeparamTest.func1(0xca37a00)
	/home/swarming/.swarming/w/ir/x/w/targetrepo2410163261/go/ssa/builder_test.go:832 +0x4d fp=0xd0c9f60 sp=0xd0c9df0 pc=0x2a16004d
testing.tRunner(0xca37a00, 0xcbc6bb8)
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1689 +0xd fp=0xd0c9fc8 sp=0xd0c9f60 pc=0x1a2c000d
testing.(*T).Run.gowrap1()
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1742 +0x2 fp=0xd0c9fe0 sp=0xd0c9fc8 pc=0x1a320002
runtime.goexit({})
	/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/asm_wasm.s:434 +0x1 fp=0xd0c9fe8 sp=0xd0c9fe0 pc=0x153c0001
created by testing.(*T).Run in goroutine 567
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1742 +0x43

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 11, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/go/ssa" && test == "TestTypeparamTest/metrics.go"
2024-09-11 20:58 x_tools-go1.22-wasip1-wasm_wazero tools@28843753 release-branch.go1.22@6fab4b9a x/tools/go/ssa.TestTypeparamTest/metrics.go [ABORT] (log)
=== RUN   TestTypeparamTest/metrics.go
    builder_test.go:805: Input: /home/swarming/.swarming/w/ir/x/w/goroot/test/typeparam/metrics.go
runtime: marked free object in span 0x1cacd00, elemsize=64 freeindex=0 (bad use of unsafe.Pointer? try -d=checkptr)
0x10b00000 free  marked   zombie
0x0000000010b00000:  0x0000000000000004  0x0000000000137fb0 
0x0000000010b00010:  0x000000000eaa2ba0  0x0000000000136ef8 
0x0000000010b00020:  0x00000000004cdbc0  0x0000000000139040 
0x0000000010b00030:  0x00000000004c12a0  0x0000000000000000 
0x10b00040 free  unmarked
0x10b00080 free  unmarked
...
fatal error: found pointer to free object

goroutine 1486 gp=0x20ae540 m=0 mp=0x4d9a60 [running]:
runtime.throw({0xb8a4e, 0x1c})
	/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/panic.go:1023 +0x3 fp=0x185e6e8 sp=0x185e6c0 pc=0x128a0003
runtime.(*mspan).reportZombies(0x1cacd00)
	/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/mgcsweep.go:875 +0x61 fp=0x185e758 sp=0x185e6e8 pc=0x11b40061
runtime.(*sweepLocked).sweep(0x185e8b0, 0x0)
	/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/mgcsweep.go:638 +0x7a fp=0x185e878 sp=0x185e758 pc=0x11af007a
runtime.sweepone()
...
golang.org/x/tools/go/ssa_test.TestTypeparamTest.func1(0xca37a00)
	/home/swarming/.swarming/w/ir/x/w/targetrepo2410163261/go/ssa/builder_test.go:832 +0x4d fp=0xd0c9f60 sp=0xd0c9df0 pc=0x2a16004d
testing.tRunner(0xca37a00, 0xcbc6bb8)
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1689 +0xd fp=0xd0c9fc8 sp=0xd0c9f60 pc=0x1a2c000d
testing.(*T).Run.gowrap1()
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1742 +0x2 fp=0xd0c9fe0 sp=0xd0c9fc8 pc=0x1a320002
runtime.goexit({})
	/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/asm_wasm.s:434 +0x1 fp=0xd0c9fe8 sp=0xd0c9fe0 pc=0x153c0001
created by testing.(*T).Run in goroutine 567
	/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1742 +0x43

watchflakes

@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 11, 2024
@gopherbot gopherbot added this to the Unreleased milestone Sep 11, 2024
@adonovan
Copy link
Member

Dup of #69410

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/612855 mentions this issue: go/ssa: go/ssa: disable TestTypeparamTest on wasm

gopherbot pushed a commit to golang/tools that referenced this issue Sep 12, 2024
watchflakes reported additional test cases for TestTypeparamTest on
wasm. Skipping the test when on wasm.

Fixes golang/go#69410
Fixes golang/go#69409

Change-Id: Icfe5da007bf7411e9875313bc1b190751f1c1a15
Reviewed-on: https://go-review.googlesource.com/c/tools/+/612855
Commit-Queue: Tim King <taking@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Tim King <taking@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Archived in project
Development

No branches or pull requests

2 participants