Skip to content

x/telemetry/internal/telemetry: update ProgramInfo heuristic for go1.24 #69401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hyangah opened this issue Sep 11, 2024 · 0 comments
Open
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. telemetry x/telemetry issues
Milestone

Comments

@hyangah
Copy link
Contributor

hyangah commented Sep 11, 2024

In go1.24, the go command will start to stamp the main module version in the build info
even when the binary is built with go build. There are cases where the binary built
in this way can have different dependencies while having the same version string stamped
as the release versions. Adjust the heuristic to detect the case.

https://github.com/golang/telemetry/blob/6d9f2eb83631e39f6d0b87dd8411b8f5d7fac38e/internal/telemetry/proginfo.go#L27

cc @golang/telemetry

@gopherbot gopherbot added the telemetry x/telemetry issues label Sep 11, 2024
@gopherbot gopherbot added this to the Unreleased milestone Sep 11, 2024
@timothy-king timothy-king added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. telemetry x/telemetry issues
Projects
None yet
Development

No branches or pull requests

3 participants