Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: retina favicon #6938

Closed
josharian opened this issue Dec 12, 2013 · 13 comments
Closed

website: retina favicon #6938

josharian opened this issue Dec 12, 2013 · 13 comments
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Milestone

Comments

@josharian
Copy link
Contributor

Any chance the golang.org favicon could get a retina-display-friendly refresh? That
little fellow is all over my tabs, and while I hear that the pixelated look is all the
rage nowadays, I can't help but think that the gopher might feel more comfortable in
crisp, high-definition blue.
@davecheney
Copy link
Contributor

Comment 1:

Labels changed: added release-none, repo-main, firstworldproblems.

Status changed to Accepted.

@josharian
Copy link
Contributor Author

Comment 2:

Nice label.

@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@bradfitz bradfitz added the Suggested Issues that may be good for new contributors looking for work to do. label Apr 13, 2016
@egonelbre
Copy link
Contributor

Because github doesn't support uploading favicon.ico and svg here with some alternatives. I can make it a CL, but not sure how good go-review is for discussing images.

favicon.ico contains sizes 16, 32, 48, 64, 110, 114, 128, 256... I can cut some of them, if necessary, because the size increase was from 1kb -> 180kb. Alternatively I can submit multiple files. However, not sure which sizes we should add.

@bradfitz bradfitz modified the milestones: Go1.8Maybe, Unplanned Aug 10, 2016
@bradfitz
Copy link
Contributor

@broady, @adg, @robpike?

@broady
Copy link
Contributor

broady commented Aug 10, 2016

This lil guy looks so perfect, but having one similar to the current but in high res would be good, too.
screen shot 2016-08-10 at 3 20 27 pm

A CL via Gerrit would be fine. I can pull apart the ico file to see what's in there.

From about 2 minutes of research, I think we just want 16 and 32.

@adg
Copy link
Contributor

adg commented Aug 10, 2016

I asked Renee and she prefers the straight one (similar to the current one). I concur. We should stick with the same color too.

@broady
Copy link
Contributor

broady commented Aug 11, 2016

adg, do you have the original? Or is it pixel art?

@adg
Copy link
Contributor

adg commented Aug 11, 2016

The original is pixel art

@bradfitz
Copy link
Contributor

Comparison of before & after CL 26850:

compare

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/26850 mentions this issue.

@egonelbre
Copy link
Contributor

Comparison with different background colors

@dsnet
Copy link
Member

dsnet commented Aug 17, 2016

What's up with the lack of alpha channels (e.g., the gross looking white outline above the head) in these previews?

@egonelbre
Copy link
Contributor

egonelbre commented Aug 17, 2016

@dsnet those are artifacts in the old favicon. Usually caused by first drawing the image on white background, then deleting the background color. Such method can only give good results when the outline isn't blended with the background.

The current state of icons http://egonelbre.com/files/favicon/

@broady broady modified the milestones: Go1.7.1, Go1.8Maybe Aug 25, 2016
gopherbot pushed a commit that referenced this issue Sep 7, 2016
Recreated original favicon with svg. Note, the rasterizations are hand
tweaked for crispness and straight export will not give the same results.

Fixes #6938

Change-Id: I9bf7b59028711361c29365b145932d90af419b69
Reviewed-on: https://go-review.googlesource.com/26850
Reviewed-by: Chris Broadfoot <cbro@golang.org>
Reviewed-on: https://go-review.googlesource.com/28639
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Aug 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Development

No branches or pull requests

9 participants