-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website: retina favicon #6938
Comments
Because github doesn't support uploading favicon.ico and svg here with some alternatives. I can make it a CL, but not sure how good go-review is for discussing images. favicon.ico contains sizes 16, 32, 48, 64, 110, 114, 128, 256... I can cut some of them, if necessary, because the size increase was from 1kb -> 180kb. Alternatively I can submit multiple files. However, not sure which sizes we should add. |
I asked Renee and she prefers the straight one (similar to the current one). I concur. We should stick with the same color too. |
adg, do you have the original? Or is it pixel art? |
The original is pixel art |
CL https://golang.org/cl/26850 mentions this issue. |
What's up with the lack of alpha channels (e.g., the gross looking white outline above the head) in these previews? |
@dsnet those are artifacts in the old favicon. Usually caused by first drawing the image on white background, then deleting the background color. Such method can only give good results when the outline isn't blended with the background. The current state of icons http://egonelbre.com/files/favicon/ |
Recreated original favicon with svg. Note, the rasterizations are hand tweaked for crispness and straight export will not give the same results. Fixes #6938 Change-Id: I9bf7b59028711361c29365b145932d90af419b69 Reviewed-on: https://go-review.googlesource.com/26850 Reviewed-by: Chris Broadfoot <cbro@golang.org> Reviewed-on: https://go-review.googlesource.com/28639 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The text was updated successfully, but these errors were encountered: