Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/go/ssa: pop Function.targets after range-over-func calls and yield bodies functions #69298

Closed
timothy-king opened this issue Sep 5, 2024 · 1 comment
Assignees
Labels
NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@timothy-king
Copy link
Contributor

During builder.{rangeFunc,buildYieldFunc} (the call to and body-of a yield function for a range-over-function) call, there are 'pushes' to Function.targets without a corresponding 'pop'.

Caught during golang/tools#514

@timothy-king timothy-king added the NeedsFix The path to resolution is known, but the work has not been done. label Sep 5, 2024
@timothy-king timothy-king self-assigned this Sep 5, 2024
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 5, 2024
@gopherbot gopherbot added this to the Unreleased milestone Sep 5, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/611055 mentions this issue: go/ssa: pop targets stack on range-over-func

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants