import/path: fs.FileInfo and fs.DirEntry,they have same two method called isDir() ,maybe should return same result? #69250

notmaster-C · 2024-09-04T10:30:38Z

Go version

go version go1.22.5 darwin/amd64

Output of `go env` in your module/workspace:

GO111MODULE='on'
GOARCH='amd64'
GOBIN=''
GOCACHE='/Users/Library/Caches/go-build'
GOENV='/Users/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMODCACHE='/Users/go/pkg/mod'
GONOPROXY='*.baidu.com*'
GONOSUMDB='*'
GOOS='darwin'
GOPATH='/Users/go'
GOPRIVATE='*.baidu.com'
GOPROXY='https://goproxy.baidu-int.com'
GOROOT='/usr/local/Cellar/go/1.22.5/libexec'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/Cellar/go/1.22.5/libexec/pkg/tool/darwin_amd64'
GOVCS=''
GOVERSION='go1.22.5'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='cc'
CXX='c++'
CGO_ENABLED='1'
GOMOD='/Users/Documents/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/l6/flvkntr11p71b8nkvzzxg43c0000gn/T/go-build3356946425=/tmp/go-build -gno-record-gcc-switches -fno-common'

What did you do?

There are two ways to determine whether an object is a file or a folder.And I got two different result.
The reason for this situation is that the existence of soft links causes the judgment to seem incorrect.

err := filepath.WalkDir(folderPath, func(path string, info os.DirEntry, err error) error {
    if !info.isDir(){
        fmt.Println(123)
    }
    fileInfo,err:=os.Stat(folderPath)
    if fileInfo.isDir() {
        fmt.Println(123)
    }
}

What did you see happen?

print:
123
123

What did you expect to see?

only print one "123"

There are two ways to determine whether an object is a file or a folder.And I got two different result.
The reason for this situation is that the existence of soft links causes the judgment to seem incorrect.

two method called isDir() maybe should return same result?

The text was updated successfully, but these errors were encountered:

gabyhelp · 2024-09-04T10:32:15Z

Related Issues and Documentation

import/path: fs.FileInfo and fs.DirEntry,they have same two method called isDir() ,maybe should return same result? #69251
Unexpected result from filepath.Dir #37890 (closed)
path/filepath: WalkDir pass unclean path to WalkDirFunc while using unclean root #50629

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

seankhliao · 2024-09-04T10:55:40Z

I believe this is working as intended: a direntry describe the file within the directory (the symlink itself) while stat follows symlinks by default.

gabyhelp mentioned this issue Sep 4, 2024

import/path: fs.FileInfo and fs.DirEntry,they have same two method called isDir() ,maybe should return same result? #69251

Closed

seankhliao closed this as not planned Sep 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

import/path: fs.FileInfo and fs.DirEntry,they have same two method called isDir() ,maybe should return same result? #69250

import/path: fs.FileInfo and fs.DirEntry,they have same two method called isDir() ,maybe should return same result? #69250

notmaster-C commented Sep 4, 2024 •

edited by seankhliao

Loading

gabyhelp commented Sep 4, 2024

seankhliao commented Sep 4, 2024

import/path: fs.FileInfo and fs.DirEntry,they have same two method called isDir() ,maybe should return same result? #69250

import/path: fs.FileInfo and fs.DirEntry,they have same two method called isDir() ,maybe should return same result? #69250

Comments

notmaster-C commented Sep 4, 2024 • edited by seankhliao Loading

Go version

Output of go env in your module/workspace:

What did you do?

What did you see happen?

What did you expect to see?

gabyhelp commented Sep 4, 2024

seankhliao commented Sep 4, 2024

notmaster-C commented Sep 4, 2024 •

edited by seankhliao

Loading

Output of `go env` in your module/workspace: