Skip to content

x/tools/gopls/internal/test/marker: Test/codeaction/fill_struct.txt failures #69010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Aug 22, 2024 · 3 comments
Closed

x/tools/gopls/internal/test/marker: Test/codeaction/fill_struct.txt failures #69010

gopherbot opened this issue Aug 22, 2024 · 3 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.17.0

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/codeaction/fill_struct.txt"

Issue created automatically to collect these failures.

Example (log):

=== RUN   Test/codeaction/fill_struct.txt
=== PAUSE Test/codeaction/fill_struct.txt
=== CONT  Test/codeaction/fill_struct.txt
    marker_test.go:244: unmeetable expectations:
        Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 15 time(s)" is met, must have:
        no log message matching ""
        
        state:
        #### log messages (see RPC logs for full text):
        	Info: "2024/08/22 02:42:20 Created View (#210)\n\tdirecto...
...
        
        #### outstanding work:
        #### completed work:
        	Setting up workspace: 1
        	Checking telemetry prompt: 1
        	diagnosing initial workspace load: 1
        	diagnosing opened files: 15
        	Analyzing Dependencies: 1
        
--- FAIL: Test/codeaction/fill_struct.txt (14.24s)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 22, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/codeaction/fill_struct.txt"
2024-08-21 17:24 x_tools-gotip-linux-riscv64 tools@c7adb631 go@98ed865a x/tools/gopls/internal/test/marker.Test/codeaction/fill_struct.txt (log) 
=== RUN   Test/codeaction/fill_struct.txt
=== PAUSE Test/codeaction/fill_struct.txt
=== CONT  Test/codeaction/fill_struct.txt
    marker_test.go:244: unmeetable expectations:
        Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 15 time(s)" is met, must have:
        no log message matching ""
        
        state:
        #### log messages (see RPC logs for full text):
        	Info: "2024/08/22 02:42:20 Created View (#210)\n\tdirecto...
...
        
        #### outstanding work:
        #### completed work:
        	Setting up workspace: 1
        	Checking telemetry prompt: 1
        	diagnosing initial workspace load: 1
        	diagnosing opened files: 15
        	Analyzing Dependencies: 1
        
--- FAIL: Test/codeaction/fill_struct.txt (14.24s)

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Aug 22, 2024
@gopherbot gopherbot added this to the Unreleased milestone Aug 22, 2024
@findleyr findleyr modified the milestones: Unreleased, gopls/v0.17.0 Sep 5, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/codeaction/fill_struct.txt"
2024-11-14 19:13 x_tools-go1.23-linux-amd64-nocgo tools@221e94d0 release-branch.go1.23@c390a1c2 x/tools/gopls/internal/test/marker.Test/codeaction/fill_struct.txt [ABORT] (log) 
=== RUN   Test/codeaction/fill_struct.txt
=== PAUSE Test/codeaction/fill_struct.txt
=== CONT  Test/codeaction/fill_struct.txt

— watchflakes

@findleyr
Copy link
Member

Neither of these are real failures of this test. Closing as unactionable.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Archived in project
Milestone
gopls/v0.17.0
Development

No branches or pull requests
2 participants
@gopherbot @findleyr