Skip to content

x/pkgsite: support viewing symbols from newer Go versions than declared in the module #68979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
codyoss opened this issue Aug 20, 2024 · 2 comments
Labels
Milestone

Comments

@codyoss
Copy link
Member

codyoss commented Aug 20, 2024

What is the URL of the page with the issue?

https://pkg.go.dev/cloud.google.com/go/secretmanager@v1.14.0/apiv1#SecretIterator

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/127.0.0.0 Safari/537.36

Screenshot

No response

What did you do?

I tried to view the docs of my newly released package for code gated by a buildtag: https://github.com/googleapis/google-cloud-go/blob/f5833e6cd8d2fc39e4decb9962062904601fc9c9/secretmanager/apiv1/auxiliary_go123.go#L17-L39

What did you see happen?

It appears that only docs are shown for the version declared in the go.mod: go 1.21: https://github.com/googleapis/google-cloud-go/blob/f5833e6cd8d2fc39e4decb9962062904601fc9c9/secretmanager/go.mod#L3

What did you expect to see?

I expect users of the library to be able to see docs for all Go versions or have the ability to select a Go version to see the docs of.

As a library maintainer it is important to me to maintain broad support for versions of Go. But it is also important for me to be able to implement and share new language features like iterator support gated by build tags.

For standard library packages it seems you can see all supported symbols, and it even lets you know when things were added. Example: https://pkg.go.dev/net/http#Request.PathValue

@codyoss codyoss changed the title x/pkgsite: support seeing newer Go versions than declared in the module x/pkgsite: support viewing symbols from newer Go versions than declared in the module Aug 20, 2024
@gopherbot gopherbot added this to the Unreleased milestone Aug 20, 2024
@gabyhelp
Copy link

Related Issues and Documentation

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@codyoss
Copy link
Member Author

codyoss commented Aug 20, 2024

Closing in favor of #68932 as it is an identical issue.

@codyoss codyoss closed this as completed Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants