Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/cgo: aix c-archive corrupting stack [1.23 backport] #68973

Closed
gopherbot opened this issue Aug 20, 2024 · 2 comments
Closed

cmd/cgo: aix c-archive corrupting stack [1.23 backport] #68973

gopherbot opened this issue Aug 20, 2024 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.23.1

Comments

@gopherbot
Copy link
Contributor

@pmur requested issue #68957 to be considered for backport to the next 1.23 minor release.

@gopherbot please consider this for backport to 1.22 and 1.23, this is a bug with no workaround.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 20, 2024
@gopherbot gopherbot mentioned this issue Aug 20, 2024
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Aug 20, 2024
@gopherbot gopherbot added this to the Go1.23.1 milestone Aug 20, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/607195 mentions this issue: [release-branch.go1.23] runtime: on AIX, fix call to _cgo_sys_thread_create in _rt0_ppc64_aix_lib

@cherrymui cherrymui added the CherryPickApproved Used during the release process for point releases label Aug 21, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Aug 21, 2024
gopherbot pushed a commit that referenced this issue Aug 21, 2024
@pmur @cherrymui
[release-branch.go1.23] runtime: on AIX, fix call to _cgo_sys_thread_…
8002845 
…create in _rt0_ppc64_aix_lib

The AIX ABI requires allocating parameter save space when calling
a function, even if the arguments are passed via registers.

gcc sometimes uses this space. In the case of the cgo c-archive
tests, it clobbered the storage space of argc/argv which prevented
the test program from running the expected test.

Fixes #68973

Change-Id: I8a267b463b1abb2b37ac85231f6c328f406b7515
Reviewed-on: https://go-review.googlesource.com/c/go/+/606895
Reviewed-by: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Paul Murphy <murp@ibm.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/607195
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
@gopherbot
Copy link
Contributor Author

Closed by merging CL 607195 (commit 8002845) to release-branch.go1.23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.23.1
Development

No branches or pull requests
2 participants
@gopherbot @cherrymui