@lfolger reported a suboptimal inliner result of this form:

    var g = foo()

    func f(x, y any) { f2(x, y) }

    // before
    f(complicated(), g)

    // after
    var ( x = complicated(); y = g )
    f2(x, y)

In this case, the inliner's effects analysis assumed conservatively that the read from global var g would not commute with the call to complicated(). However, the variable g is not address-taken and is assigned only in its declaration.

The inliner's effects analysis should enumerate all non-address-taken variables (non-exported variables that appear in an lvalue position only in their own declaration) and allow reads of them to commute with global effects such as complicated(), resulting in this more optimal inlining: f2(g, complicated()).