New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
syscall: missing sockios.h defines #6894
Labels
Comments
i think we generally only include what's used by the Go standard library and what is needed to use other part of the syscall package. The other problem is that, even if we could add it to the syscall package, you probably don't want to force your user to use Go tip before Go 1.3 is released. And if you use conditional compilation to also support older Go versions, you need to add the definition to your source code anyway. Status changed to Unfortunate. |
> i think we generally only include what's used by the Go standard library > and what is needed to use other part of the syscall package. That doesn't seem to be the case, as a recursive grep of, for example SIOCADDDLCI, shows no in-tree users: ~/goroot/src/pkg $ grep -r SIOCADDDLCI syscall/zerrors_linux_amd64.go: SIOCADDDLCI = 0x8980 syscall/zerrors_linux_386.go: SIOCADDDLCI = 0x8980 syscall/zerrors_linux_arm.go: SIOCADDDLCI = 0x8980 > The other problem is that, even if we could add it to the syscall package, > you probably don't want to force your user to use Go tip before Go 1.3 > is released. And if you use conditional compilation to also support older > Go versions, you need to add the definition to your source code anyway. I'm not really concerned about this issue, it's no problem to define the constant within docker in the mean time (or permanently if Go doesn't support it). |
that constant was added 3 years ago (https://golang.org/cl/2303043). After Go 1 is released, we're more strict about adding things to the syscall package. |
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
by joshpoimboeuf:
The text was updated successfully, but these errors were encountered: