Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: iter: Enumerate, Keys and Values functions #68887

Closed
mymmrac opened this issue Aug 15, 2024 · 4 comments
Closed

proposal: iter: Enumerate, Keys and Values functions #68887

mymmrac opened this issue Aug 15, 2024 · 4 comments
Labels
Proposal
Milestone
Proposal

Comments

@mymmrac
Copy link

mymmrac commented Aug 15, 2024 •
edited
Loading

Proposal Details

I think it's will be common to work with iter.Seq and iter.Seq2 simultaneously, but there is no quick way to go from iter.Seq to iter.Seq2 and vice versa, so I propose to add new functions for iter package

func Enumerate[T any](it iter.Seq[T]) iter.Seq2[int, T] {
	return func(yield func(int, T) bool) {
		i := 0
		for v := range it {
			if !yield(i, v) {
				return
			}
			i++
		}
	}
}
func Keys[T1, T2 any](it iter.Seq2[T1, T2]) iter.Seq[T1] {
	return func(yield func(T1) bool) {
		for k := range it {
			if !yield(k) {
				return
			}
		}
	}
}
func Values[T1, T2 any](it iter.Seq2[T1, T2]) iter.Seq[T2] {
	return func(yield func(T2) bool) {
		for _, v := range it {
			if !yield(v) {
				return
			}
		}
	}
}
@gopherbot gopherbot added this to the Proposal milestone Aug 15, 2024
@gabyhelp
Copy link

Related Issues and Documentation

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@mymmrac
Copy link
Author

mymmrac commented Aug 15, 2024

Proposal #67334 introduces more flexible, but complex ways to handle this issue
Proposal #61898 doesn't touch on issue of going from iter.Seq to iter.Seq2 and vice versa

@ianlancetaylor ianlancetaylor moved this to Incoming in Proposals Aug 15, 2024
@jimmyfrasche
Copy link
Member

The top level comment of #61898 does not touch on but these all have come up in the discussion (along with their generalizations).

@mymmrac
Copy link
Author

mymmrac commented Aug 15, 2024 •
edited
Loading

I found a comment about those functions, and the explanations seem reasonable, so I guess this is just a duplicate issue, closing it

@mymmrac mymmrac closed this as not planned Won't fix, can't repro, duplicate, stale Aug 15, 2024
@gabyhelp gabyhelp mentioned this issue Sep 28, 2024
Closed
@gabyhelp gabyhelp mentioned this issue Nov 11, 2024
Closed
@gabyhelp gabyhelp mentioned this issue Dec 24, 2024
Closed
@gabyhelp gabyhelp mentioned this issue Feb 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Proposal
Projects
None yet
Milestone
Proposal
Development

No branches or pull requests
4 participants
@jimmyfrasche @gopherbot @mymmrac @gabyhelp