Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: ApplyFix: "no file for edit position" bug in suggestedFixToDocumentChange (via telemetry) #68818

Open
adonovan opened this issue Aug 9, 2024 · 4 comments
Open

x/tools/gopls: ApplyFix: "no file for edit position" bug in suggestedFixToDocumentChange (via telemetry) #68818

adonovan opened this issue Aug 9, 2024 · 4 comments
Labels
Documentation Issues describing a change to documentation. gopls/telemetry-wins gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/backlog

Comments

@adonovan
Copy link
Member

adonovan commented Aug 9, 2024 •
edited
Loading 

#!stacks
"bug.Errorf" && "golang.suggestedFixToDocumentChange:+10"

This stack Di2gNg was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
golang.org/x/tools/gopls/internal/golang.suggestedFixToDocumentChange:+10
golang.org/x/tools/gopls/internal/golang.ApplyFix:+47
golang.org/x/tools/gopls/internal/server.(*commandHandler).ApplyFix.func1:+1
golang.org/x/tools/gopls/internal/server.(*commandHandler).run.func2:+3
golang.org/x/tools/gopls/internal/server.(*commandHandler).run:+73
golang.org/x/tools/gopls/internal/server.(*commandHandler).ApplyFix:+2
golang.org/x/tools/gopls/internal/protocol/command.Dispatch:+25
golang.org/x/tools/gopls/internal/server.(*server).ResolveCodeAction:+21
golang.org/x/tools/gopls/internal/protocol.serverDispatch:+46
golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.ServerHandler.func3:+5
golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.handshaker.func4:+52
golang.org/x/tools/gopls/internal/protocol.Handlers.MustReplyHandler.func1:+2
golang.org/x/tools/gopls/internal/protocol.Handlers.AsyncHandler.func2.2:+3
runtime.goexit:+0

golang.org/x/tools/gopls@v0.16.1 go1.22.0 darwin/arm64 other,vscode (3)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.
Dups: jFMuhg hN-HyA Q_lWOg
@adonovan adonovan added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. gopls/telemetry-wins labels Aug 9, 2024
@gopherbot gopherbot added this to the Unreleased milestone Aug 9, 2024
@gopherbot gopherbot added the Documentation Issues describing a change to documentation. label Aug 9, 2024
@gabyhelp
Copy link

gabyhelp commented Aug 9, 2024

Related Issues and Documentation

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@adonovan adonovan modified the milestones: Unreleased, gopls/backlog Aug 15, 2024
@adonovan
Copy link
Member Author

This stack jFMuhg was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.20.7 darwin/arm64 other,vscode (1)

@adonovan
Copy link
Member Author

This stack hN-HyA was reported by telemetry:

golang.org/x/tools/gopls@v0.17.0-pre.2 go1.23.3 linux/amd64 vscode (1)

@gabyhelp gabyhelp mentioned this issue Nov 27, 2024
Open
@gabyhelp gabyhelp mentioned this issue Dec 18, 2024
Closed
@adonovan
Copy link
Member Author

This stack Q_lWOg was reported by telemetry:

golang.org/x/tools/gopls@v0.18.1 go1.23.6 linux/amd64 vscode (1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation Issues describing a change to documentation. gopls/telemetry-wins gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/backlog
Development

No branches or pull requests
3 participants
@adonovan @gopherbot @gabyhelp