Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: reuse x/website's TestAll for catching problems in release note fragments in the main Go repository #68633

Closed
dmitshur opened this issue Jul 29, 2024 · 2 comments
Assignees
Labels
Builders x/build issues (builders, bots, dashboards) Friction Nuisances that make good candidates for our "friction" fix-it weeks NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Jul 29, 2024

x/website has an excellent test for issue #37047 that catches various problems in Markdown/HTML content. However, there's some content like the upcoming release notes draft written outside of the x/website repository, so sometimes we'll learn about a problem only after the CL was already submitted. That usually means a follow-up CL ends up being needed, like CL 600656 (for issue #68575), CL 587415, etc.

We can configure LUCI to automatically add an x/website trybot and run this test whenever files in doc/next of the main Go repo are modified. That should help catch these kinds of issues.

CC @golang/release, @jba.

@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. Friction Nuisances that make good candidates for our "friction" fix-it weeks labels Jul 29, 2024
@dmitshur dmitshur added this to the Unreleased milestone Jul 29, 2024
@dmitshur dmitshur self-assigned this Jul 29, 2024
@dmitshur dmitshur moved this to In Progress in Go Release Jul 29, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/601656 mentions this issue: main.star: add a linux/amd64 x/website trybot for release note CLs

@gopherbot
Copy link
Contributor

Closed by merging CL 601656 (commit golang/build@0ec9bc3) to luci-config.

gopherbot pushed a commit to golang/build that referenced this issue Jul 29, 2024
Copying the test to the main Go repository requires vendoring x/net/html
as a test-only dependency, which works (prototype in go.dev/cl/600816)
but adds size and requires a copy of the test to be maintained in an
extra place.

Instead, reuse x/website's test by invoking it as a trybot. This is
viable because x/website tests pick up main Go tree content from the
runtime.GOROOT() directory, which is what the trybot ends up using as
its Go version. (Checked in go.dev/cl/601039.)

For golang/go#37047.
Fixes golang/go#68633.

Change-Id: I69cc638c489cbb847e7b46e4af90e0197ddd6695
Reviewed-on: https://go-review.googlesource.com/c/build/+/601656
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Release Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) Friction Nuisances that make good candidates for our "friction" fix-it weeks NeedsFix The path to resolution is known, but the work has not been done.
Projects
Archived in project
Development

No branches or pull requests

2 participants