You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
dmitshur opened this issue
Jul 29, 2024
· 2 comments
Assignees
Labels
Buildersx/build issues (builders, bots, dashboards)FrictionNuisances that make good candidates for our "friction" fix-it weeksNeedsFixThe path to resolution is known, but the work has not been done.
x/website has an excellent test for issue #37047 that catches various problems in Markdown/HTML content. However, there's some content like the upcoming release notes draft written outside of the x/website repository, so sometimes we'll learn about a problem only after the CL was already submitted. That usually means a follow-up CL ends up being needed, like CL 600656 (for issue #68575), CL 587415, etc.
We can configure LUCI to automatically add an x/website trybot and run this test whenever files in doc/next of the main Go repo are modified. That should help catch these kinds of issues.
The text was updated successfully, but these errors were encountered:
dmitshur
added
Builders
x/build issues (builders, bots, dashboards)
NeedsFix
The path to resolution is known, but the work has not been done.
Friction
Nuisances that make good candidates for our "friction" fix-it weeks
labels
Jul 29, 2024
Copying the test to the main Go repository requires vendoring x/net/html
as a test-only dependency, which works (prototype in go.dev/cl/600816)
but adds size and requires a copy of the test to be maintained in an
extra place.
Instead, reuse x/website's test by invoking it as a trybot. This is
viable because x/website tests pick up main Go tree content from the
runtime.GOROOT() directory, which is what the trybot ends up using as
its Go version. (Checked in go.dev/cl/601039.)
For golang/go#37047.
Fixesgolang/go#68633.
Change-Id: I69cc638c489cbb847e7b46e4af90e0197ddd6695
Reviewed-on: https://go-review.googlesource.com/c/build/+/601656
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Buildersx/build issues (builders, bots, dashboards)FrictionNuisances that make good candidates for our "friction" fix-it weeksNeedsFixThe path to resolution is known, but the work has not been done.
x/website has an excellent test for issue #37047 that catches various problems in Markdown/HTML content. However, there's some content like the upcoming release notes draft written outside of the x/website repository, so sometimes we'll learn about a problem only after the CL was already submitted. That usually means a follow-up CL ends up being needed, like CL 600656 (for issue #68575), CL 587415, etc.
We can configure LUCI to automatically add an x/website trybot and run this test whenever files in doc/next of the main Go repo are modified. That should help catch these kinds of issues.
CC @golang/release, @jba.
The text was updated successfully, but these errors were encountered: