-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: perf builders are failing to build cockroachdb for baseline at tip #68555
Comments
Related Issues and Documentation
(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.) |
This should be fixed by https://go.dev/cl/600196. |
No, sorry, it's still broken as of that CL, and I see now @dmitshur noticed that above. |
Ugh, I can't seem to reproduce the failure locally... This is making me think there's something specifically about the environment of the builder that's causing problems, or perhaps how |
@mknyszek Could the problem be that the baseline toolchain is something like 1.22 so the constraints in runtime_go1.20_21_22.go match, but because sweet now sets the |
I think you're right. Ideally, we'd fix this in CockroachDB upstream, but alternatively Sweet could be more careful to only set that build tag if it's actually on an unreleased version. I think the alternative is somewhat unstable in the long run, but it would work in the short run. |
Change https://go.dev/cl/600475 mentions this issue: |
Change https://go.dev/cl/600495 mentions this issue: |
It's already annoying to have to ask for longtest builders to run the end-to-end test for sweet, but the fact that we also forget to run the Go 1.22 end-to-end test means we get real breakages like golang/go#68555. Resolve this once and for all by enabling longtest in presubmit if any Go file is touched by a CL in the x/benchmarks repository. Change-Id: Ia76258edf9bc93b88501cd64755beddd39186f06 Reviewed-on: https://go-review.googlesource.com/c/build/+/600495 Auto-Submit: Michael Knyszek <mknyszek@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
The gotip-linux-amd64_{c2s16,c3h88}-perf_vs_release builders are failing at tip due sweet running into an error building cockroachdb for baseline:
For example, see https://logs.chromium.org/logs/golang/buildbucket/cr-buildbucket/8741671757414064545/+/u/step/20/log/2.
There was an
untested_go_version
mechanism added a month ago in cockroachdb/cockroach@e513328 which may be relevant, since gotip represents the early development cycle of Go 1.24 now. Edit: CL 600196 already took that into account yesterday. (CC @aclements.)CC @mknyszek, @dr2chase.
The text was updated successfully, but these errors were encountered: