Skip to content

x/telemetry/internal/mmap: TestSharedMemory failures #68389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Jul 11, 2024 · 8 comments
Closed

x/telemetry/internal/mmap: TestSharedMemory failures #68389

gopherbot opened this issue Jul 11, 2024 · 8 comments
Assignees
@findleyr
Labels
NeedsFix The path to resolution is known, but the work has not been done. telemetry x/telemetry issues
Milestone
Go1.23

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
default <- pkg == "golang.org/x/telemetry/internal/mmap" && test == "TestSharedMemory"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestSharedMemory
    mmap_test.go:101: incremented 99 times, want 100
--- FAIL: TestSharedMemory (0.14s)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 11, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/telemetry/internal/mmap" && test == "TestSharedMemory"
2024-07-10 14:37 x_telemetry-go1.21-linux-arm telemetry@809510d1 release-branch.go1.21@e073febe x/telemetry/internal/mmap.TestSharedMemory (log) 
=== RUN   TestSharedMemory
    mmap_test.go:101: incremented 99 times, want 100
--- FAIL: TestSharedMemory (0.14s)
2024-07-11 14:58 x_telemetry-go1.21-linux-arm telemetry@ac0359c6 release-branch.go1.21@e073febe x/telemetry/internal/mmap.TestSharedMemory (log) 
=== RUN   TestSharedMemory
    mmap_test.go:101: incremented 99 times, want 100
--- FAIL: TestSharedMemory (0.13s)

— watchflakes

@gopherbot gopherbot added the telemetry x/telemetry issues label Jul 11, 2024
@gopherbot gopherbot added this to the Unreleased milestone Jul 11, 2024
@findleyr findleyr modified the milestones: Unreleased, Go1.23 Jul 11, 2024
@findleyr findleyr self-assigned this Jul 11, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/597815 mentions this issue: internal/mmap: read resulting file contents via mmap in TestSharedMemory

gopherbot pushed a commit to golang/telemetry that referenced this issue Jul 12, 2024
@findleyr
internal/mmap: read resulting file contents via mmap in TestSharedMemory
Loading
Loading status checks…
1f628dd 
To avoid sync issues, read the final file contents using mmap in
TestSharedMemory.

For golang/go#68389

Change-Id: Iff3bad3b8ea5c8448e20e0fadd798036137cf275
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/597815
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
@findleyr
Copy link
Member

Waiting for a bit to see that this does not flake.

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/telemetry/internal/mmap" && test == "TestSharedMemory"
2024-07-12 15:15 x_telemetry-go1.21-linux-arm telemetry@d9d12e83 release-branch.go1.21@e073febe x/telemetry/internal/mmap.TestSharedMemory (log) 
=== RUN   TestSharedMemory
    mmap_test.go:101: incremented 99 times, want 100
--- FAIL: TestSharedMemory (0.12s)
2024-07-12 20:54 x_telemetry-go1.21-linux-arm telemetry@1f628dd3 release-branch.go1.21@e073febe x/telemetry/internal/mmap.TestSharedMemory (log) 
=== RUN   TestSharedMemory
    mmap_test.go:102: incremented 99 times, want 100
--- FAIL: TestSharedMemory (0.13s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/telemetry/internal/mmap" && test == "TestSharedMemory"
2024-07-16 16:07 x_telemetry-go1.21-linux-arm telemetry@44ac6ef1 release-branch.go1.21@e073febe x/telemetry/internal/mmap.TestSharedMemory (log) 
=== RUN   TestSharedMemory
    mmap_test.go:102: incremented 99 times, want 100
--- FAIL: TestSharedMemory (0.13s)
2024-07-16 19:19 x_telemetry-go1.21-linux-arm telemetry@fb0bb5c6 release-branch.go1.21@e073febe x/telemetry/internal/mmap.TestSharedMemory (log) 
=== RUN   TestSharedMemory
    mmap_test.go:102: incremented 99 times, want 100
--- FAIL: TestSharedMemory (0.11s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/telemetry/internal/mmap" && test == "TestSharedMemory"
2024-07-18 16:59 x_telemetry-go1.21-linux-arm telemetry@79a4c46d release-branch.go1.21@dabed2e0 x/telemetry/internal/mmap.TestSharedMemory (log) 
=== RUN   TestSharedMemory
    mmap_test.go:102: incremented 99 times, want 100
--- FAIL: TestSharedMemory (0.12s)
2024-07-19 15:28 x_telemetry-go1.21-linux-arm telemetry@4b97e47a release-branch.go1.21@dabed2e0 x/telemetry/internal/mmap.TestSharedMemory (log) 
=== RUN   TestSharedMemory
    mmap_test.go:102: incremented 98 times, want 100
--- FAIL: TestSharedMemory (0.11s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/600915 mentions this issue: internal/mmap: on 1.21 linux/arm, skip tests relying on 64-bit atomics

@dmitshur dmitshur moved this to Active in Test Flakes Jul 24, 2024
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jul 24, 2024
@github-project-automation github-project-automation bot moved this from Active to Done in Test Flakes Aug 5, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/telemetry/internal/mmap" && test == "TestSharedMemory"
2024-07-24 20:04 x_telemetry-go1.21-linux-arm telemetry@9f7bb9a1 release-branch.go1.21@dabed2e0 x/telemetry/internal/mmap.TestSharedMemory (log) 
=== RUN   TestSharedMemory
    mmap_test.go:102: incremented 98 times, want 100
--- FAIL: TestSharedMemory (0.13s)
2024-07-24 21:01 x_telemetry-go1.21-linux-arm telemetry@b54ba84a release-branch.go1.21@dabed2e0 x/telemetry/internal/mmap.TestSharedMemory (log) 
=== RUN   TestSharedMemory
    mmap_test.go:102: incremented 98 times, want 100
--- FAIL: TestSharedMemory (0.11s)

— watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
NeedsFix The path to resolution is known, but the work has not been done. telemetry x/telemetry issues
Projects
Test Flakes
Archived in project
Milestone
Go1.23
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @findleyr