Skip to content

x/build/cmd/relui: consider failing to add a reviewer a soft failure #68276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dmitshur opened this issue Jul 2, 2024 · 1 comment
Open

x/build/cmd/relui: consider failing to add a reviewer a soft failure #68276

dmitshur opened this issue Jul 2, 2024 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Jul 2, 2024

Right now the CreateAutoSubmitChange method is willing to create a CL, fail to add a reviewer, and report the failure to the caller. This leaves CLs behind and is generally not the optimal behavior. Instead it should log the problem but otherwise proceed, provided the CL itself was successfully created.

CC @golang/release, @thanm.
@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Jul 2, 2024
@dmitshur dmitshur added this to the Unreleased milestone Jul 2, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/595616 mentions this issue: internal/task: add a workaround for a reviewer account not existing

gopherbot pushed a commit to golang/build that referenced this issue Jul 2, 2024
@dmitshur @gopherbot
internal/task: add a workaround for a reviewer account not existing
Loading
Loading status checks…
5b05406 
For golang/go#68276.

Change-Id: I2169a573c9c64415cd4d524cf378e5a313784e32
Reviewed-on: https://go-review.googlesource.com/c/build/+/595616
Reviewed-by: Than McIntosh <thanm@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
@dmitshur dmitshur moved this to Planned in Go Release Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Status: Planned
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot